From nobody Fri Jun 27 18:56:23 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTPsk083Fz607DG; Fri, 27 Jun 2025 18:56:26 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTPsj3z5Rz3J5B; Fri, 27 Jun 2025 18:56:25 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751050585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3vBNzVFZETWadBY0/NkqKppYUaHUJItBSFkjRSXb31Y=; b=mf5x/8i4Q/QV7j9iUZ89OhwhPIq5wVEG5sA6Oa5Mf56/CBB6X6jqV6MHDT2PMX/B/t44zE MTTzAplxG/YF9sIiRmF/qE9gDd9StQDqckRgkq7INSyLkbjcAbJb2DsEzLomB9dplTDxLZ /Bp0AkNJgDoYBN/T8L7tNl+F0v9EtQAshYKjDj465uwxM6wK1KGj9GZW02qWilqLbiW97B aIsEKoc01dUPnPMA3EctnkJsQIvh0VjuJ8JfNqWO+yuYb/9/juzv7HAwsDDrSxe6zcuF8g 7FED0imPdQo+qA3tD6UDp69oSPW/qyIWeuRfoTLAJSdNppvCCa7ze2uzEIhU0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751050585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3vBNzVFZETWadBY0/NkqKppYUaHUJItBSFkjRSXb31Y=; b=ZY4JYozqLbYcYbsU3V7lkQfxZg05xXvQMOM3VwbDSVTeDwYBiLkwobWlSlel1jvAjAQrvZ JptWZ8HnyFYEQ3O4WU5zIr93En13ngXgzmmdlEuwgAH3BlKmR3emlRm62IO+dHRPpy45ZT jNklvphHCc2mwiFWodYlvtbvXMeMRHNLPssSen45txqRguStCetoNycSNbAjdRC+OLMz1J gg3W2mbse8wqi/ufExoyLA63VQPc+ibs9ZSDTCda546fUxvTP8l3iEeuMsOTHON9aIXOES 4me3971r6tNo69OVg1wzPBLviaSY9dx4SrHkp9FFJrXUKBVg6ehnQytzVTcwYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751050585; a=rsa-sha256; cv=none; b=XCM2du09uXAxIUqrNEl70EaM8Zh7c5oe9eyEr3qbHy/ADD2VdrVIhCBRjLbykJZfuAOSAe rGyo/xnlRDvqqaFbVu+70YZmv9h0qyrCniautCQy8JbJOpCvjG4pm/W/Q0NN9WZxDE3Zb5 WGW3S5FDsif26MMvFbOMt+JNr3MovGkHPIbSPeGBCJxprhGh/7JZrTk08UnSf3utWyyxJq l2lKfJnTf1k+Dm+dGNwvadGOxgP0YGaxK/4qYqTibzzzNhlifXu9u88YtF3GwRb5TeiUCZ tHYGsyzJCPdMs0oQTpJEtYpdj9sQy1A84CinLmPQVxHmQAoIlfAqzvQqdJ7KDQ== Received: from b.nours.eu (b.nours.eu [54.38.177.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bTPsj16ylzCPs; Fri, 27 Jun 2025 18:56:25 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by b.nours.eu (Postfix, from userid 1001) id A2C1391FDD; Fri, 27 Jun 2025 20:56:23 +0200 (CEST) Date: Fri, 27 Jun 2025 20:56:23 +0200 From: Baptiste Daroussin To: Mark Johnston Cc: Hiroki Sato , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4deb9760a9d8 - main - rc: Disable pathname expansion when calling run_rc_command() Message-ID: References: <202506121820.55CIKQTQ097365@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed 18 Jun 10:13, Mark Johnston wrote: > On Thu, Jun 12, 2025 at 06:20:26PM +0000, Hiroki Sato wrote: > > The branch main has been updated by hrs: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4deb9760a9d84d5861ee45162ffebe83f13503b8 > > > > commit 4deb9760a9d84d5861ee45162ffebe83f13503b8 > > Author: Hiroki Sato > > AuthorDate: 2025-06-12 18:19:32 +0000 > > Commit: Hiroki Sato > > CommitDate: 2025-06-12 18:19:32 +0000 > > > > rc: Disable pathname expansion when calling run_rc_command() > > > > Variables for command-line options like $foo_flags can contain characters > > that perform pathname expansions, such as '[', ']', and '*'. They were > > passed without escaping, and the matched entries in the working directory > > affected the command-line options. This change turns off the expansion > > when run_rc_command() is called. > > > > While this changes the current behavior, an invocation of a service > > program should not depend on entries in the working directory. > > This also turns off globbing for /etc/rc.local, which broke one of my > scripts. Was that intentional? If so, we should really document it in > RELNOTES at the very least. This broke nuageinit which rely on globbing to in nuageinit_start, that this change also broke. So many downstream CI are now broken, due to this change. Best regards, Bapt