From nobody Fri Apr 4 23:23:41 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZTvmz51jWz5sbVr; Fri, 04 Apr 2025 23:23:47 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZTvmz0J8Rz3VbY; Fri, 04 Apr 2025 23:23:47 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7c5e2fe5f17so248539685a.3; Fri, 04 Apr 2025 16:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743809025; x=1744413825; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=Umw1+sK3JlLczvqaArquLggNDd+t4YG9fK7EmCCeKYo=; b=b5uBB2oP7581AE2j/xqCkEQj6zhpMjWRjDLiAdpNiGt71UW79iFd3MUtONEIqUxhMl FWVxleGRFVXXEgKv9XGoqvZCO7FhB7spts0Bo3YonWrDgJW1GmF0xSNFzUsSR/6Ng5m+ vpVjOrA4SoCn/FYLRgN0QPz3Yjaa2V6vMq24JGqENzUe/+QmwRo9C0FpujSA44i7EQBp MP4X1CdTdKa0Yp2KYITDpxiZQrMoMsFzt3JvzaQifSNJMgpv6/FYZAhtodtq5hWLcpub XnSu9R9MoiV8CkZQKIiJD/ebi68wjW5S6YJWoBY/zoNKoicTpIg6NWEfhkf3t2356StG kPpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743809025; x=1744413825; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Umw1+sK3JlLczvqaArquLggNDd+t4YG9fK7EmCCeKYo=; b=X+cxCX6atFZ0zbYYocEKWlnIFJNHTup/Ca7qA2SRPndH/k+57anMyF9fxsV6Em0WlN LC28YYFLetKxXb3HyKRGxWGcQC+SDilqMg+J/h1kZ5SYOn2hbsJvS70Kf8iApDeuPXWK SVPEDoNGWKNNif5PBk3ibnxQt2V762KnHZnGwcw1tTQJheWeCMmJ+w4EsFlMOWmowZXd QBrrul80rbKQw4FRfHX70VHb1hqSDuiKz+AjgHIEgjpeGTx0mf4hkinw8V51LqFOd/Ml m7k4J1AsonuPDtM5qUQebj8jcLmzqUVn3bYlgzGI58MU69skVFYtWR9w0FRrSM9LE1VB fEig== X-Forwarded-Encrypted: i=1; AJvYcCW3AT3he9VrUOfqfJhqQoIzRceAA342qBfmNx/7KJYhwKNYzXQ3OZai5DANTZHA+oeZC0xX8kB11SNcVlszc112TeY3RnE=@freebsd.org, AJvYcCWFlxE30JZk8uCjQo4/GtMD5of9lXQUo9ZdV9LHt4hwUSa93W6TRbvq6kIiWOEmqLE/FthNJAKpjceJoRw+cSSsEZNF@freebsd.org, AJvYcCX1NZ/HXJPR6Qk2tb0MsarbSP3kyLrJ0/z+4aJsVBVWSnt1XQGSOBgCXdBD89LR+wZDHa65V2VqSWuB/tdb91I=@freebsd.org X-Gm-Message-State: AOJu0YxcX6asFKojl3yz09Z/JZ95cr/uodl/xVpuJ8UALv7qWpUvQJmg Pu+ef2tqNZs2gk1Uo3qVxLmNY5SBCHDW2XsMMeE17Fmf6yBEgOlPf08i6yop3cw= X-Gm-Gg: ASbGnctOSS5ugkDqnhpiiESYjKD5SDRmuWJeAaf3B5lItNz8TfaTwxg5C/AR+r4W/LA t5XFllAopTVFwNG7OHeglHnaasd14V40HEOQg0zMw98T30m4PWJB3dDYLSI5grdEF1eE+PrHbgd +GomR97vf9fnEvuQVqCLb4eJbRU3DTiRASWazu8OrOeNIoZEJEjre78tIGE5OGJv+3/f9Ke03lu RVaFSPS2aGqttmBNDPuGD3Ht5JY2I2RlVll2jdID7eqOx92WL3CMORUZugY6CWW12C/6HW/Gk9e 1z5CA9ZyREP8E2Mn3d5GcQY/FiWaODCpgFo+4HYvXeOlh64MDOTHefmPOqk= X-Google-Smtp-Source: AGHT+IFPpAQXfSQiPBfTy/0wHLQPhvimXVMGw3xDw6o/JkFN3QlNXTCRAbImVBKyXqgRWbiYPTzhsw== X-Received: by 2002:a05:620a:24c6:b0:7c5:4949:2400 with SMTP id af79cd13be357-7c77dd6b3d4mr220408685a.9.1743809025268; Fri, 04 Apr 2025 16:23:45 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c76e75ec7bsm272868685a.43.2025.04.04.16.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 16:23:44 -0700 (PDT) Date: Fri, 4 Apr 2025 19:23:41 -0400 From: Mark Johnston To: Tom Jones Cc: Colin Percival , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 74a6f2a76b32 - main - iwx: Shorten log code field Message-ID: References: <202504030707.53377PCW040790@gitrepo.freebsd.org> <01000195fcbbe2ed-0afa2175-1e23-4d89-bda4-5bd86437b3a2-000000@email.amazonses.com> <1db1061f-f8a7-40d8-b9b3-e3a81bdfaebf@app.fastmail.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1db1061f-f8a7-40d8-b9b3-e3a81bdfaebf@app.fastmail.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4ZTvmz0J8Rz3VbY X-Spamd-Bar: ---- On Fri, Apr 04, 2025 at 09:41:27PM +0100, Tom Jones wrote: > Sorry for the breakage, something has broken in my mail filters so direct mails to me aren’t landing in my inbox when also sent to src-commits (just the folder for commits). > > I’ll look at this as soon as I can (probably not until Monday). If you want to remove iwx from the build (or just i386 in the meantime) please do. I removed iwx from the i386 build yesterday: https://cgit.freebsd.org/src/commit/?id=296b60793df6ae855ba414fbf4823467e9615b2f > > On Thu, Apr 3, 2025, at 18:38, Colin Percival wrote: > > On 4/3/25 00:07, Tom Jones wrote: > >> commit 74a6f2a76b32e01d05c4ad71897bd3a6831e703e > >> > >> This fixes the build on i386. > > > > You sure about that? > > > > /usr/src/sys/dev/iwx/if_iwx.c:5762:22: error: shift count >= width of type > > [-Werror,-Wshift-count-overflow] > > 5762 | if (data->cmd_paddr >> 32 != (data->cmd_paddr + > > le32toh(desc->tbs[0].tb_len)) >> 32) > > | ^ ~~ > > /usr/src/sys/dev/iwx/if_iwx.c:5762:80: error: shift count >= width of type > > [-Werror,-Wshift-count-overflow] > > 5762 | if (data->cmd_paddr >> 32 != (data->cmd_paddr + > > le32toh(desc->tbs[0].tb_len)) >> 32) > > | > > ^ ~~ > > /usr/src/sys/dev/iwx/if_iwx.c:5769:22: error: shift count >= width of type > > [-Werror,-Wshift-count-overflow] > > 5769 | if (data->cmd_paddr >> 32 != (data->cmd_paddr + > > le32toh(desc->tbs[1].tb_len)) >> 32) > > | ^ ~~ > > /usr/src/sys/dev/iwx/if_iwx.c:5769:80: error: shift count >= width of type > > [-Werror,-Wshift-count-overflow] > > 5769 | if (data->cmd_paddr >> 32 != (data->cmd_paddr + > > le32toh(desc->tbs[1].tb_len)) >> 32) > > | > > ^ ~~ > > /usr/src/sys/dev/iwx/if_iwx.c:5778:23: error: shift count >= width of type > > [-Werror,-Wshift-count-overflow] > > 5778 | if (data->cmd_paddr >> 32 != (data->cmd_paddr + > > le32toh(desc->tbs[i + 2].tb_len)) >> 32) > > | ^ ~~ > > /usr/src/sys/dev/iwx/if_iwx.c:5778:85: error: shift count >= width of type > > [-Werror,-Wshift-count-overflow] > > 5778 | if (data->cmd_paddr >> 32 != (data->cmd_paddr + > > le32toh(desc->tbs[i + 2].tb_len)) >> 32) > > | > > ^ ~~ > > /usr/src/sys/dev/iwx/if_iwx.c:10971:47: error: format specifies type 'unsigned > > long' but the argument has type 'uint64_t' (aka 'unsigned long long') > > [-Werror,-Wformat] > > 10971 | DPRINTF(("%s: k->wk_keytsc=%lu\n", __func__, k->wk_keytsc)); > > | ~~~ ^~~~~~~~~~~~ > > | %llu > > > > -- > > Colin Percival > > FreeBSD Release Engineering Lead & EC2 platform maintainer > > Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid > > -- > - Tom >