From owner-dev-commits-src-all@freebsd.org Wed Sep 15 23:59:50 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2383B670C1D; Wed, 15 Sep 2021 23:59:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H8xzB0RYFz3mnG; Wed, 15 Sep 2021 23:59:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E2AC117468; Wed, 15 Sep 2021 23:59:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 18FNxnHw011094; Wed, 15 Sep 2021 23:59:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 18FNxnij011093; Wed, 15 Sep 2021 23:59:49 GMT (envelope-from git) Date: Wed, 15 Sep 2021 23:59:49 GMT Message-Id: <202109152359.18FNxnij011093@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Piotr Pawel Stefaniak Subject: git: b5541f456d64 - main - diff: convert boolean flag variables to bool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pstef X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b5541f456d641d23e0c46874daff0b62552bf3cb Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 23:59:50 -0000 The branch main has been updated by pstef: URL: https://cgit.FreeBSD.org/src/commit/?id=b5541f456d641d23e0c46874daff0b62552bf3cb commit b5541f456d641d23e0c46874daff0b62552bf3cb Author: Piotr Pawel Stefaniak AuthorDate: 2021-09-04 23:44:26 +0000 Commit: Piotr Pawel Stefaniak CommitDate: 2021-09-15 23:36:41 +0000 diff: convert boolean flag variables to bool There will be more boolean flags added in upcoming commits and they would have to be stored in ints in order to be consistent with existing code. Change the existing code to use the bool type. --- usr.bin/diff/diff.c | 23 +++++++++++------------ usr.bin/diff/diff.h | 8 +++++--- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/usr.bin/diff/diff.c b/usr.bin/diff/diff.c index bfd391a4e3dd..03eb16211e86 100644 --- a/usr.bin/diff/diff.c +++ b/usr.bin/diff/diff.c @@ -38,8 +38,9 @@ __FBSDID("$FreeBSD$"); #include "diff.h" #include "xmalloc.h" -int lflag, Nflag, Pflag, rflag, sflag, Tflag, cflag, Wflag; -int diff_format, diff_context, status, ignore_file_case, suppress_common; +bool lflag, Nflag, Pflag, rflag, sflag, Tflag, cflag; +bool ignore_file_case, suppress_common; +int diff_format, diff_context, status; int tabsize = 8, width = 130; char *start, *ifdefname, *diffargs, *label[2], *ignore_pats; char *group_format = NULL; @@ -147,7 +148,6 @@ main(int argc, char **argv) case 'c': if (FORMAT_MISMATCHED(D_CONTEXT)) conflicting_format(); - cflag = 1; diff_format = D_CONTEXT; if (optarg != NULL) { l = strtol(optarg, &ep, 10); @@ -199,10 +199,10 @@ main(int argc, char **argv) usage(); break; case 'l': - lflag = 1; + lflag = true; break; case 'N': - Nflag = 1; + Nflag = true; break; case 'n': if (FORMAT_MISMATCHED(D_NREVERSE)) @@ -213,10 +213,10 @@ main(int argc, char **argv) dflags |= D_PROTOTYPE; break; case 'P': - Pflag = 1; + Pflag = true; break; case 'r': - rflag = 1; + rflag = true; break; case 'q': if (FORMAT_MISMATCHED(D_BRIEF)) @@ -227,10 +227,10 @@ main(int argc, char **argv) start = optarg; break; case 's': - sflag = 1; + sflag = true; break; case 'T': - Tflag = 1; + Tflag = true; break; case 't': dflags |= D_EXPANDTABS; @@ -251,7 +251,6 @@ main(int argc, char **argv) dflags |= D_IGNOREBLANKS; break; case 'W': - Wflag = 1; width = (int) strtonum(optarg, 1, INT_MAX, &errstr); if (errstr) { warnx("Invalid argument for width"); @@ -278,10 +277,10 @@ main(int argc, char **argv) case OPT_HORIZON_LINES: break; /* XXX TODO for compatibility with GNU diff3 */ case OPT_IGN_FN_CASE: - ignore_file_case = 1; + ignore_file_case = true; break; case OPT_NO_IGN_FN_CASE: - ignore_file_case = 0; + ignore_file_case = false; break; case OPT_NORMAL: if (FORMAT_MISMATCHED(D_NORMAL)) diff --git a/usr.bin/diff/diff.h b/usr.bin/diff/diff.h index 28d08288e1e9..04e75e631954 100644 --- a/usr.bin/diff/diff.h +++ b/usr.bin/diff/diff.h @@ -33,6 +33,8 @@ */ #include + +#include #include /* @@ -90,9 +92,9 @@ struct excludes { struct excludes *next; }; -extern int lflag, Nflag, Pflag, rflag, sflag, Tflag, cflag, Wflag; -extern int diff_format, diff_context, status, ignore_file_case; -extern int suppress_common; +extern bool lflag, Nflag, Pflag, rflag, sflag, Tflag, cflag; +extern bool ignore_file_case, suppress_common; +extern int diff_format, diff_context, status; extern int tabsize, width; extern char *start, *ifdefname, *diffargs, *label[2], *ignore_pats; extern char *group_format;