Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 Jun 2018 16:24:10 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 227109] Mk/Scripts, cleanup using devel/hs-ShellCheck
Message-ID:  <bug-227109-7788-AIgcM74Ldz@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-227109-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-227109-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227109

Mathieu Arnold <mat@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193646|0                           |1
        is obsolete|                            |

--- Comment #18 from Mathieu Arnold <mat@FreeBSD.org> ---
Created attachment 193895
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D193895&action=
=3Dedit
base commit: r471274

First non "noop" commit:

    SC2046: Quote this to prevent word splitting.

    When command expansions are unquoted, word splitting and globbing will
    occur. This often manifests itself by breaking when filenames contain
    spaces.

    Trying to fix it by adding quotes or escapes to the data will not work.
    Instead, quote the command substitution itself.

    If the command substitution outputs multiple pieces of data, use a loop
    instead.

    Add an exception when using set -- where splitting is intended.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227109-7788-AIgcM74Ldz>