Date: Mon, 1 Jul 2013 01:19:08 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Felippe de Meirelles Motta <lippe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r321982 - in head/net: . hanstunnel hanstunnel/files Message-ID: <20130701011908.GB9325@FreeBSD.org> In-Reply-To: <201306282045.r5SKjaZb090161@svn.freebsd.org> References: <201306282045.r5SKjaZb090161@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 28, 2013 at 08:45:36PM +0000, Felippe de Meirelles Motta wrote: > New Revision: 321982 > URL: http://svnweb.freebsd.org/changeset/ports/321982 > > +# Created by: Alexander Panyushkin <vsityz@gmail.com> > +# $FreeBSD$ > + > +PORTNAME= hans > +PORTVERSION= 0.4.1 > +CATEGORIES= net security > +MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} > +MASTER_SITE_SUBDIR= /hanstunnel/source/ Submitter apparently does not how to use MASTER_SITES/MASTER_SITE_SUBDIR combo propopery: make fetch DISTDIR=/tmp ===> portaudit database exists, however, portaudit is not installed! => hans-0.4.1.tar.gz doesn't seem to exist in /tmp/. => Attempting to fetch http://nchc.dl.sourceforge.net/project//hanstunnel/source//hans-0.4.1.tar.gz ... Note the bogus double slashes. Correct, modern way is to simple write: MASTER_SITES= SF/hanstunnel/source > +MAINTAINER= vsityz@gmail.com > +COMMENT= Hans makes it possible to tunnel IPv4 through ICMP It's generally wrong to start COMMENT line with "Foobar is..." or alikes. Better comment in this case would be smth. like "Program to tunnel IPv4 through ICMP echo packets". > +LICENSE_PERMS_GPL3= yes Why not just "LICENSE= GPLv3" ?? > +OPTIONS_DEFINE= CLANG > + > +CLANG_DESC= Build with Clang instead of GCC > + > +OPTIONS_DEFAULT= CLANG I don't really see the point of such option. As there any noticeable changes which warrant this selection, or submitter just wanted to play with Clang a bit? :-) Imagine a user (not a developer) building this port: such a dialog would probably puzzle him/her. > .if ${PORT_OPTIONS:MCLANG} > .if ${OSVERSION} < 1000000 > CC=clang > CXX=clang++ > .if ${OSVERSION} < 900033 > BUILD_DEPENDS+= clang:${PORTSDIR}/lang/clang > .endif > .endif > .else > USE_GCC=4.2+ > CC=gcc > CXX=g++ > CPP=gcpp > .endif Bad indentation (lack there of). > +do-install: > + @${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} ${WRKSRC}/hans ${LOCALBASE}/bin Why not simply use INSTALL_PROGRAM here? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130701011908.GB9325>