From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Jul  8 21:40:25 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7F02116A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  8 Jul 2004 21:40:25 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 743A743D2D
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  8 Jul 2004 21:40:25 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i68LePSe088216	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 8 Jul 2004 21:40:25 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i68LePcT088215;
	Thu, 8 Jul 2004 21:40:25 GMT
	(envelope-from gnats)
Date: Thu, 8 Jul 2004 21:40:25 GMT
Message-Id: <200407082140.i68LePcT088215@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Rui Lopes <rui@ruilopes.com>
Subject: Re: ports/68769: [PATCH] devel/maven: update to 1.0.r4 and
	MASTER_SITE_APACHE
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Rui Lopes <rui@ruilopes.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jul 2004 21:40:25 -0000

The following reply was made to PR ports/68769; it has been noted by GNATS.

From: Rui Lopes <rui@ruilopes.com>
To: herve.quiroz@esil.univ-mrs.fr
Cc: Volker Stolz <vs@freebsd.org>, freebsd-gnats-submit@freebsd.org
Subject: Re: ports/68769: [PATCH] devel/maven: update to 1.0.r4 and MASTER_SITE_APACHE
Date: Thu, 08 Jul 2004 22:37:35 +0100

 Hi Volker,
 
 Volker Stolz wrote:
  > - Update to 1.0.r4
  > - Use ${MASTER_SITE_APACHE}
  > - Set and use ${DATADIR} as suggested in [1]
  > - ${DISTNAME} is now set according to ${PORTVERSION}
 
 I'm OK with all changes except this one:
  > - post-configure -> do-configure
 
 Basically I fell we shouln't override the default targets (the do-XXX) 
 and only override the pre- and post- ones, this way the port system is 
 free to have a default action for the do-XXX (maybe not applicable right 
 now for java ports, but maybe in future it will).
 
 
 [...]
  > To sum up, the first two change items are quite needed (update to 
 1.0rc4 and
  > MASTER_SITE_APACHE) but the last three ones are more cosmetic 
 changes. Feel
  > free to tell me your opinion on the subject and should you disagree with
  > something in this PR, I will provide a new patch to match your 
 suggestions.
  >
  >
  > [1] Porter's handbook - Using Java - Best practices
  > 
 http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-java.html#JAVA-BEST-PRACTICES
 
 Nice, we now have a Java section :)
 
 
 Thanks for updating the port Volker!
 
 
 Best regards,
 Rui Lopes