From owner-svn-src-head@freebsd.org Thu Jul 5 23:18:14 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 06132103E124; Thu, 5 Jul 2018 23:18:14 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (unknown [IPv6:2a01:4f8:d12:604::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E1367BC0A; Thu, 5 Jul 2018 23:18:13 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w65NI6un023293 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Jul 2018 01:18:07 +0200 (CEST) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: jhb@FreeBSD.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w65NI3Rg089573 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 6 Jul 2018 06:18:03 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: svn commit: r335916 - head/sys/conf To: John Baldwin , Konstantin Belousov References: <201807032305.w63N5guY063293@repo.freebsd.org> <20180704142233.GB5562@kib.kiev.ua> <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org> <20180705155417.GI5562@kib.kiev.ua> <2a5b1c50-0f50-bbe1-4fcd-b98f61d24571@FreeBSD.org> Cc: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Eugene Grosbein Message-ID: <5B3EA725.4010202@grosbein.net> Date: Fri, 6 Jul 2018 06:17:57 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <2a5b1c50-0f50-bbe1-4fcd-b98f61d24571@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00, LOCAL_FROM, RDNS_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.1 X-Spam-Report: * -0.0 SPF_PASS SPF: sender matches SPF record * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 2.6 LOCAL_FROM From my domains * 1.9 RDNS_NONE Delivered to internal network by a host with no rDNS X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 23:18:14 -0000 06.07.2018 1:21, John Baldwin wrote: > Yes, this is a change though I find it the logical outcome of the original change > to move away from MODULES_WITH_WORLD. And to be clear, Matt certainly only > intended to use MODULE_TIED in a few places, but I think tagging all those > places will be cumbersome and tedious compared to just doing it in this way. I > think this will also tie into something I proposed earlier in a commit reply and > that I also brought up at BSDCan which is that I think that kernel modules in > ports should install their sources and build glue to some location we choose > (e.g. /usr/local/sys/modules/) and that we should support a variable folks > can set in their kernel config file similar to MODULES_OVERRIDE that is a list > of local modules to recompile and install into /boot/kernel along with other > modules (and that these recompiled modules would be TIED). The binary module > from the package would still be present in /boot/modules, but the tied module > in /boot/kernel would be preferred and used instead when it exists (our existing > module_path already does this last part). This would replace the existing > PORTS_MODULES but in a way that is more graceful and works with packages, not > just ports IMO. I'm not sure I understand the topic quite right, but please do not drop MODULES_WITH_WORLD support at it allows us to quickly rebuild the kernel in case of slight changes of its config file not changing ABI and/or similar source changes without HUGE modules compilation overhead. Also, we should not use /usr/local/sys/modules/ as /usr/local can be inaccessible for the loader. Better use /boot/modules/local or /boot/local as /boot is guaranteed to be accessible.