From owner-svn-src-head@FreeBSD.ORG  Sun Dec 14 09:32:34 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5FF621065670;
	Sun, 14 Dec 2008 09:32:34 +0000 (UTC)
	(envelope-from yanefbsd@gmail.com)
Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.238])
	by mx1.freebsd.org (Postfix) with ESMTP id 1DB268FC08;
	Sun, 14 Dec 2008 09:32:33 +0000 (UTC)
	(envelope-from yanefbsd@gmail.com)
Received: by rv-out-0506.google.com with SMTP id b25so2241747rvf.43
	for <multiple recipients>; Sun, 14 Dec 2008 01:32:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:to
	:subject:cc:in-reply-to:mime-version:content-type
	:content-transfer-encoding:content-disposition:references;
	bh=BXyVz2p5yWurasHVY0pZi8hhlyKXtCaIxRD/SZeYiNE=;
	b=AI1kLsATa5mfoKG5XTar/aquFDxF3hHuaU3N+pNC27ZWU24IS2eJ7OOF2P2LF4XL1E
	1DNoDKU3eqs9wO0NzQACby9HFAZSMpG7tRcpD9hyL1poraiuNJPP66o2MydtaDBhYHcu
	N7YhtXa8MOv65jSpioRXEqATVjgHLsgykwOvk=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
	:content-type:content-transfer-encoding:content-disposition
	:references;
	b=G8amJe4C+rnFFxCUUPvEnsHkZPoYWA1DG/HOr3xiTOR68nLlR/BUHNzqLJw7wWnlvp
	JIiUyBXynTJaQ2hHM2u4uY1mbnEA9RBI/Q+W6+jJEt4bd0vBU0OHgzJ/q9rvUklp7OO2
	PjtKMNPiUGTNzPXqtwRjKCY8xNyt5mE2RvSs8=
Received: by 10.141.177.10 with SMTP id e10mr2980210rvp.137.1229247153752;
	Sun, 14 Dec 2008 01:32:33 -0800 (PST)
Received: by 10.140.158.13 with HTTP; Sun, 14 Dec 2008 01:32:33 -0800 (PST)
Message-ID: <7d6fde3d0812140132u54d9785chb81f96aa3e10d204@mail.gmail.com>
Date: Sun, 14 Dec 2008 01:32:33 -0800
From: "Garrett Cooper" <yanefbsd@gmail.com>
To: "Niclas Zeising" <niclas.zeising@gmail.com>
In-Reply-To: <4944D17E.9080900@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200812140906.mBE96SEZ054272@svn.freebsd.org>
	<7d6fde3d0812140108l4b0c75e1o229c667c0b86dd7e@mail.gmail.com>
	<4944D17E.9080900@gmail.com>
Cc: svn-src-head@freebsd.org, Joseph Koshy <jkoshy@freebsd.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r186076 - head/sys/amd64/amd64
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Dec 2008 09:32:34 -0000

On Sun, Dec 14, 2008 at 1:27 AM, Niclas Zeising
<niclas.zeising@gmail.com> wrote:
> Garrett Cooper wrote:
>>
>> On Sun, Dec 14, 2008 at 1:06 AM, Joseph Koshy <jkoshy@freebsd.org> wrote:
>>>
>>> Author: jkoshy
>>> Date: Sun Dec 14 09:06:28 2008
>>> New Revision: 186076
>>> URL: http://svn.freebsd.org/changeset/base/186076
>>>
>>> Log:
>>>  Bug fix: %ebx needs to be preserved in the user callchain capture
>>>  path.
>>>
>>> Modified:
>>>  head/sys/amd64/amd64/exception.S
>>>
>>> Modified: head/sys/amd64/amd64/exception.S
>>>
>>> ==============================================================================
>>> --- head/sys/amd64/amd64/exception.S    Sun Dec 14 06:40:04 2008
>>>  (r186075)
>>> +++ head/sys/amd64/amd64/exception.S    Sun Dec 14 09:06:28 2008
>>>  (r186076)
>>> @@ -459,9 +459,9 @@ nmi_calltrap:
>>>        */
>>>       movq    %rsp,%rsi       /* source stack pointer */
>>>       movq    $TF_SIZE,%rcx
>>> -       movq    PCPU(RSP0),%rbx
>>> -       subq    %rcx,%rbx
>>> -       movq    %rbx,%rdi       /* destination stack pointer */
>>> +       movq    PCPU(RSP0),%rdx
>>> +       subq    %rcx,%rdx
>>> +       movq    %rdx,%rdi       /* destination stack pointer */
>>>
>>>       shrq    $3,%rcx         /* trap frame size in long words */
>>>       cld
>>> @@ -470,7 +470,7 @@ nmi_calltrap:
>>>
>>>       movl    %ss,%eax
>>>       pushq   %rax            /* tf_ss */
>>> -       pushq   %rbx            /* tf_rsp (on kernel stack) */
>>> +       pushq   %rdx            /* tf_rsp (on kernel stack) */
>
>                   ^^^^^^
>>>
>>>       pushfq                  /* tf_rflags */
>>>       movl    %cs,%eax
>>>       pushq   %rax            /* tf_cs */
>>
>> Stupid question -- where's the change? All I see are potentially
>> whitespace modifications..
>> -Garrett
>
> %rbx is changed to a %rdx in some places, I hilighted one.
> Regards!
> //Niclas

Yeah, I know. I'm just blind as a bat ><.
-Garrett