From owner-svn-ports-all@FreeBSD.ORG  Tue Jan 14 14:16:54 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id BDE56CE0; Tue, 14 Jan 2014 14:16:54 +0000 (UTC)
Date: Tue, 14 Jan 2014 14:16:54 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: TAKATSU Tomonari <tota@FreeBSD.org>
Subject: Re: svn commit: r338361 - in head/devel/silentbob: . files
Message-ID: <20140114141654.GA47381@FreeBSD.org>
References: <201401010649.s016nJ4w004860@svn.freebsd.org>
 <20140113082949.GB8735@FreeBSD.org>
 <CANaE3C-Dy18HAiXhFuhiHyM7GoKPqNAHtSd4OHHwHGp_bNZb=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANaE3C-Dy18HAiXhFuhiHyM7GoKPqNAHtSd4OHHwHGp_bNZb=g@mail.gmail.com>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2014 14:16:54 -0000

On Tue, Jan 14, 2014 at 10:14:19PM +0900, TAKATSU Tomonari wrote:
> 2014/1/13 Alexey Dokuchaev <danfe@freebsd.org>:
> Thank you for pointing out my mistakes.

Thank you for taking my feedback constructively.

> -.include <bsd.port.options.mk>
> -

This hunk is OK.

>  post-patch:
>         @${RM} ${WRKSRC}/CMakeCache.txt
>         @${REINPLACE_CMD} -e
> 's|/usr/lib/silent_bob/|${PREFIX}/lib/silent_bob/|' \
>                 ${WRKSRC}/src/init.cxx

Here we have a minor problem: REINPLACE_CMD statement is a bit too long, and
causes a line wrap.  Would you consider this equivalent, but shorter version
instead:

	@${REINPLACE_CMD} -e '/lib\/silent_bob/s|/usr|${PREFIX}|' \
		${WRKSRC}/src/init.cxx

It also is more vocal: for lib/silent_bob, we change /usr into ${PREFIX},
and reduces duplication ("silent_bob" is spelled only once).

>  post-install:
>         @${MKDIR} ${STAGEDIR}${DOCSDIR}
> -       @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
> -.endif
> +       ${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}

This part is OK.

./danfe