From owner-freebsd-xen@FreeBSD.ORG  Wed May 13 14:52:18 2015
Return-Path: <owner-freebsd-xen@FreeBSD.ORG>
Delivered-To: freebsd-xen@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D7648629
 for <freebsd-xen@freebsd.org>; Wed, 13 May 2015 14:52:18 +0000 (UTC)
Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (Client CN "mail.citrix.com",
 Issuer "Cybertrust Public SureServer SV CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8A13E14C2
 for <freebsd-xen@freebsd.org>; Wed, 13 May 2015 14:52:18 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="5.13,421,1427760000"; d="scan'208";a="262286439"
Message-ID: <5553651D.3000400@citrix.com>
Date: Wed, 13 May 2015 16:52:13 +0200
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: "Eggert, Lars" <lars@netapp.com>
CC: "freebsd-xen@freebsd.org" <freebsd-xen@freebsd.org>
Subject: Re: Xen dom0 "interrupt storm detected on "irq16:";
 throttling interrupt source"
References: <EAB58E00-BA0A-45FB-A709-01359219C106@netapp.com>
 <55531131.7040404@citrix.com>
 <65D7289A-9261-4F02-88E5-B2D137C268C1@netapp.com>
In-Reply-To: <65D7289A-9261-4F02-88E5-B2D137C268C1@netapp.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussion of the freebsd port to xen - implementation and usage
 <freebsd-xen.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen/>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 14:52:18 -0000

El 13/05/15 a les 15.48, Eggert, Lars ha escrit:
> isci0: <Intel(R) C600 Series Chipset SAS Controller (SATA mode)> port 0x6000-0x60ff mem 0xde07c000-0xde07ffff,0xddc00000-0xddffffff irq 16 at device 0.0 on pci10
> isci0: attempting to allocate 2 MSI-X vectors (2 supported)
> isci: 1:000089 ISCI bus_alloc_resource failed

This device is sharing the same IRQ#16 with ehci0, and I have a feeling 
it's not properly setting up it's interrupt sources. First, FreeBSD 
Dom0 still doesn't support MSI-X (only MSI), but isci doesn't check the 
errors returned by pci_alloc_msix. I have a patch for FreeBSD which 
might solve it, however I don't have any similar box I can use to test 
it, would you mind giving it a spin?

Thanks, Roger.

---
diff --git a/sys/x86/xen/xen_msi.c b/sys/x86/xen/xen_msi.c
index 0f678b1..181b956 100644
--- a/sys/x86/xen/xen_msi.c
+++ b/sys/x86/xen/xen_msi.c
@@ -114,6 +114,7 @@ int
 xen_msix_alloc(device_t dev, int *irq)
 {
 
+	*irq = -1;
 	return (ENXIO);
 }