From owner-svn-src-all@FreeBSD.ORG Wed Nov 9 13:27:17 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 766CF1065672; Wed, 9 Nov 2011 13:27:17 +0000 (UTC) (envelope-from rwatson@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 00BC08FC0A; Wed, 9 Nov 2011 13:27:17 +0000 (UTC) Received: from [172.20.47.5] (unknown [12.21.1.3]) by cyrus.watson.org (Postfix) with ESMTPSA id 75B8846B23; Wed, 9 Nov 2011 08:27:16 -0500 (EST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Robert N. M. Watson" In-Reply-To: <86r51lcyn2.fsf@kopusha.home.net> Date: Wed, 9 Nov 2011 08:27:16 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <2494F45C-AEEA-43D6-B373-AACF747A09B6@freebsd.org> References: <201111061047.pA6AlKnc017568@svn.freebsd.org> <86r51lcyn2.fsf@kopusha.home.net> To: Mikolaj Golub X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227207 - in head/sys: netinet netinet6 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2011 13:27:17 -0000 On 6 Nov 2011, at 05:51, Mikolaj Golub wrote: > On Sun, 6 Nov 2011 10:47:20 +0000 (UTC) Mikolaj Golub wrote: >=20 > MG> Author: trociny > MG> Date: Sun Nov 6 10:47:20 2011 > MG> New Revision: 227207 > MG> URL: http://svn.freebsd.org/changeset/base/227207 >=20 > MG> Log: > MG> Cache SO_REUSEPORT socket option in inpcb-layer in order to = avoid > MG> inp_socket->so_options dereference when we may not acquire the = lock on > MG> the inpcb. > MG> =20 > MG> This fixes the crash due to NULL pointer dereference in > MG> in_pcbbind_setup() when inp_socket->so_options in a pcb returned = by > MG> in_pcblookup_local() was checked. > MG> =20 > MG> Reported by: dave jones , Arnaud = Lacombe > MG> Suggested by: rwatson > MG> Glanced by: rwatson > MG> Tested by: dave jones >=20 > This commit fixes the panic reported by Dave for 9.0 triggered by > named. Robert has helped very much suggesting the solution and looking > at the patches. Unfortunately being saturated on free time he > couldn't do thorough review of the final version confirming only that > presumably the approach was correct. >=20 > I made an effort to check that there was no regression and = SO_REUSEADDR > worked the same way as it had worked before. But I can't be 100% = confident > that I haven't broken something. Because of this I am going to MFC > only after the release. >=20 > Here is the initial discussion of the issue: >=20 > = http://lists.freebsd.org/pipermail/freebsd-net/2011-September/029858.html Hi Mikolaj: In light of some additional reports of races reminiscent of this one = (i.e., the UDP crash report on net@ a few days ago), I wonder if we = should change plans and attempt to get this in the release? I'm sorry I = haven't had a chance to do a more thorough review, and will try to get = to that later this week now that my current batch of meetings is winding = down. Robert=