From owner-svn-src-all@freebsd.org Wed Dec 21 19:07:04 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 384DBC8B41B for ; Wed, 21 Dec 2016 19:07:04 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yb0-x232.google.com (mail-yb0-x232.google.com [IPv6:2607:f8b0:4002:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EBE021436 for ; Wed, 21 Dec 2016 19:07:03 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yb0-x232.google.com with SMTP id d59so75702138ybi.1 for ; Wed, 21 Dec 2016 11:07:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Q0w/zXpp8NUdfrw83aBc2iVscTfrephNbCYPwhlobnY=; b=wXXBKPlxYfS931wBTvnoSQDxZap+yiB+UEPrC4ZhU1EprBZTzxYip+IT+4jtJze+eI wlgvCwvreazqObMnb2iBh5ROhNJkLo1MVMEJTZJHh1UDp1vp33cJlHUMM1hXUof0yCD4 WpsfMsOnIYfdRTKn5zKgwmZFcpXDx889iR3sbt18ECpM6Zp+vQ5idOok5QS2km3dcv1B FVwiIl9cCEkQoRNrwunbwzkwJazDXOQvaK0TMHa/oO/jeO4bJXIh9G9+reNpKfTpW1tq IYm/Hnq4osAnHHaOCnW5OQoUWk1YACbC0/jKHjYYLOhPhn2P93HbARdob3FZHWa7OIyx yR3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Q0w/zXpp8NUdfrw83aBc2iVscTfrephNbCYPwhlobnY=; b=jDvPCzbFcDAPRKBXxWeZzom6UwIZERX1VFQWINMMONDtRb0HEx4wJewZUDMhZWC9O3 zFldA1D4iXla0ytWqYpJLghjqAtVUk4sSeTeBVLDL7iUy1dcuv0vNKBOVK1wqwl4Wfqf Ga7tyU2QrTjNaFMHy1dNiYIg7aq5DtFzzY9i+EIP0abtVdVOhoqyt9PGjjcj/wAsclMP 7ESO+G3l5+tzdxN5VmRCZlU2KFpEgfqrH25PALeUEcmSO6nWiHe1o7jhyeC5zBjIjM9O CQsclkp8HfO8R3LpKPT61nyS5kBJwT0d6FHlKj8ttiCppIPuyGvnyNSaJHGwgcrXnHO4 Fueg== X-Gm-Message-State: AIkVDXK18t7iQ2ibNyKXERYDCXAcdtwd1zofWt4TwrdgX7BXYxAjflCHJM+fl1fuhBHwy+xAxj0+BjOxSCdh8w== X-Received: by 10.37.210.197 with SMTP id j188mr3667513ybg.168.1482347223062; Wed, 21 Dec 2016 11:07:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.2.139 with HTTP; Wed, 21 Dec 2016 11:06:32 -0800 (PST) In-Reply-To: References: <201612210829.uBL8Tijt041811@repo.freebsd.org> From: Ed Schouten Date: Wed, 21 Dec 2016 20:06:32 +0100 Message-ID: Subject: Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter To: Adrian Chadd Cc: Ed Schouten , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 19:07:04 -0000 Hi Adrian, 2016-12-21 18:32 GMT+01:00 Adrian Chadd : > Maybe just "sysctl_export" would be fine. Good point. Almost all Prometheus metrics exporters use this naming scheme: ~80%: ${foo}_exporter ~20%: prometheus_${foo}_exporter Examples; - https://github.com/prometheus/node_exporter - https://github.com/ewr/elasticsearch_exporter - https://github.com/jonnenauha/prometheus_varnish_exporter The reason why I went for the 'prometheus_' prefix was mainly because of the following totally subjective reasons: - I didn't want to wreck tab completion. Right now if you type in 'sysc' and press tab, it tends to complete to 'sysctl'. - This tool is part of the base system, meaning that it will be present even if the user did nothing special. This is why I wanted the name to be a bit more self-documenting. - Thinking ahead: what if we're going to add exporters for other things as well? E.g., for Sendmail, sshd, ftpd, HAST, etc. In that case it would be nicer if those exporters shared a common prefix. That said, if people truly think it's a good idea to call this sysctl_exporter instead, then I wouldn't mind renaming it. Thoughts? Opinions? -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717