From owner-freebsd-net Sat Jul 29 15:14:30 2000 Delivered-To: freebsd-net@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id 8136A37B621 for ; Sat, 29 Jul 2000 15:14:24 -0700 (PDT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 29 Jul 2000 23:14:23 +0100 (BST) To: Bosko Milekic Cc: David Malone , Alfred Perlstein , net@FreeBSD.ORG Subject: Re: Mbuf stuff. In-reply-to: Your message of "Sat, 29 Jul 2000 16:56:49 EDT." X-Request-Do: Date: Sat, 29 Jul 2000 23:14:22 +0100 From: David Malone Message-ID: <200007292314.aa22039@salmon.maths.tcd.ie> Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > /usr/src/sys/sys/mbuf.h > > > > The call to _MEXTFREE in MFREE is wrapped in braces, which > > I think goes against style(9). > That's up to you, it makes no difference to me. I don't remember > seeing anything specifically _against_ it in style(9) but I'm not sure. It says: "No braces are used for control statements with zero or only a single statement unless that statement is more than a single line in which case they are permitted." > > Should we comment the fact that _MEXTFREE has to be called > > at splimp? > Not really necessary, because it always is called at splimp(), and > it's not the exported macro. The "exported" version of the macro wraps > _MEXTFREE at MBUFLOCK(), and it's called MEXTFREE(). _MEXT_DEALLOC_CNT is also internal, but has an XXX somment saying it should be called at splimp(), which it always is. I just thought it would be more consistant to have a comment for both. > Thank you very much for bringing all this stuff up! Glad to be useful ;-) Do you want to make a new version of the patch available, or should Alfred make the changes as he commits? David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message