Date: Sun, 08 Sep 2013 11:52:53 +0200 From: Oliver Lehmann <oliver@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r326685 - in head: devel/mercator math/wfmath Message-ID: <20130908115253.Horde.idQUkFxUdsyF3rNQX9eeBA2@avocado.salatschuessel.net> In-Reply-To: <20130908033306.GA54749@FreeBSD.org> References: <201309072043.r87KhjYi068970@svn.freebsd.org> <20130908033306.GA54749@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev <danfe@freebsd.org> wrote: > This is notoriously bad commit message. In fact, it's almost as bad as an > empty one. > unclear is 1) what kind of error this commit is supposed to fix; USE_GCC was introduces because: It requires a gcc compiler to compile. Next time I'll think more about the message to make this more clear. > 2) why is it hard to create a proper patch instead; Why? I can't tell, I'm sorry - I just was not able to fix the clang compilation problems otherwise. > 3) is it really necessary to set USE_GCC to "yes", not "any"? This is what the header of bsd.gcc.mk suggests. If "any" is prefered over "yes", it should be stated somewhere in the top of bsd.gcc.mk - maybe in the Examples section which is where I always look first. Greetings, Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130908115253.Horde.idQUkFxUdsyF3rNQX9eeBA2>