From owner-cvs-all@FreeBSD.ORG Mon May 26 14:26:53 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06F5937B401; Mon, 26 May 2003 14:26:53 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B4B243FA3; Mon, 26 May 2003 14:26:52 -0700 (PDT) (envelope-from gibbs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h4QLQq0U016968; Mon, 26 May 2003 14:26:52 -0700 (PDT) (envelope-from gibbs@repoman.freebsd.org) Received: (from gibbs@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h4QLQqCI016967; Mon, 26 May 2003 14:26:52 -0700 (PDT) Message-Id: <200305262126.h4QLQqCI016967@repoman.freebsd.org> From: "Justin T. Gibbs" Date: Mon, 26 May 2003 14:26:52 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/aic7xxx aic79xx.c aic79xx.reg aic79xx.seq aic79xx_inline.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2003 21:26:53 -0000 gibbs 2003/05/26 14:26:52 PDT FreeBSD src repository Modified files: sys/dev/aic7xxx aic79xx.c aic79xx.reg aic79xx.seq aic79xx_inline.h Log: Correct/Simplify ignore wide residue message handling aic79xx.c: In ahd_handle_ign_wide_residue(): o Use SCB_XFERLEN_ODD SCB field to determine transfer "oddness" rather than the DATA_COUNT_ODD logic. SCB_XFERLEN_ODD is toggled on every ignore wide residue message so that multiple ignore wide residue messages for the same transaction are properly supported. o If the sg list has been exausted, the sequencer doesn't bother to update the residual data count since it is known to be zero. Perform the zeroing manually before calculating the remaining data count. o Use multibyte in/out macros instead of shifting/masking by hand. aic79xx_inline.h: In ahd_setup_scb_common(), setup the SCB_XFERLEN_ODD field. aic79xx.reg: Use the SCB_TASK_ATTRIBUTE field as a bit field in the non-packetized case. We currently only define one bit, SCB_XFERLEN_ODD. Remove the ODD_SEG bit field that was used to carry the odd transfer length information through the SG cache. This is obviated by SCB_XFERLEN_ODD field. Remove the DATA_COUNT_ODD scratch ram byte that was used dynamicaly compute data transfer oddness. This is obviated by SCB_XFERLEN_ODD field. aic79xx.seq: Remove all updates to the DATA_COUNT_ODD scratch ram field. Remove all uses of ODD_SEG. These two save quite a few sequencer instructions. Use SCB_XFERLEN_ODD to validate the end of transfer ignore wide residue message case. Revision Changes Path 1.15 +24 -32 src/sys/dev/aic7xxx/aic79xx.c 1.13 +7 -2 src/sys/dev/aic7xxx/aic79xx.reg 1.11 +4 -13 src/sys/dev/aic7xxx/aic79xx.seq 1.11 +7 -2 src/sys/dev/aic7xxx/aic79xx_inline.h