From owner-svn-src-all@FreeBSD.ORG Wed Apr 9 18:37:34 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4C7438C1; Wed, 9 Apr 2014 18:37:34 +0000 (UTC) Received: from mail.ignoranthack.me (ujvl.x.rootbsd.net [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 244891DB6; Wed, 9 Apr 2014 18:37:33 +0000 (UTC) Received: from [192.168.1.104] (c-24-6-177-88.hsd1.ca.comcast.net [24.6.177.88]) (using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 590271929A9; Wed, 9 Apr 2014 18:37:32 +0000 (UTC) Subject: Re: svn commit: r264280 - in head/sys: conf modules From: Sean Bruno To: John Baldwin In-Reply-To: <201404091430.43469.jhb@freebsd.org> References: <201404082139.s38LdqbY028535@svn.freebsd.org> <201404091147.08716.jhb@freebsd.org> <1397065504.1121.6.camel@powernoodle.corp.yahoo.com> <201404091430.43469.jhb@freebsd.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-BouWE21Qm1oMmFFJONMr" Date: Wed, 09 Apr 2014 11:37:31 -0700 Message-ID: <1397068651.1121.8.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: sbruno@freebsd.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2014 18:37:34 -0000 --=-BouWE21Qm1oMmFFJONMr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-04-09 at 14:30 -0400, John Baldwin wrote: > On Wednesday, April 09, 2014 1:45:04 pm Sean Bruno wrote: > > On Wed, 2014-04-09 at 11:47 -0400, John Baldwin wrote: > > > On Tuesday, April 08, 2014 5:39:52 pm Sean Bruno wrote: > > > > Author: sbruno > > > > Date: Tue Apr 8 21:39:51 2014 > > > > New Revision: 264280 > > > > URL: http://svnweb.freebsd.org/changeset/base/264280 > > > >=20 > > > > Log: > > > > Actually, since this is what I thought I was doing, only allow th= e > > > > binmisc code to be build on amd64/i386 for the kernel. > > > > =20 > > > > Update NOTES with some indication of what this code is used for. > > > > =20 > > > > Pointed out by jhb@ ... thanks! > > > > =20 > > > > Submitted by: jhb@ > > > >=20 > > > > Modified: > > > > head/sys/conf/NOTES > > > > head/sys/conf/options.amd64 > > > > head/sys/conf/options.i386 > > > > head/sys/modules/Makefile > > >=20 > > > Why not enable it on all platforms? I don't see anything inherently > > > MD about it. > > >=20 > >=20 > >=20 > > This is purely an artifact of my comfort level with the code and the > > cases that I am using/testing. > >=20 > > If someone can verify that it works on other architectures, I'm more > > than happy to enable on all platforms. >=20 > Does it build on other platforms? I think it is better to enable it if > it builds to avoid bitrot. >=20 Untested. I agree that its better, I just haven't done it. I think this was a protective measure on my part to not inflict more work upon myself as I was already slight agitated at how long it took to get to the point of getting mips32 support implemented via qemu. =20 sean --=-BouWE21Qm1oMmFFJONMr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAABAgAGBQJTRZNrAAoJEBkJRdwI6BaHAvkH/Ra0u88BVM4NNG9r/90beN+R mjvUZ+Txmi+jqR4j8+EQf7+32JXpoDzpIAjWM4Y3w08KZBg5MjOenl5XJLZAwtZi 65SWXzX/xFVIxiKoXCv5b3gXpIejAypLC6jsK8mKOte3i9mwmQs4Nn6hpyrts7Ju jSYP2jQEHSVe8CXUPktMDP/z9Y5dGMrD8nux8hb9GbRcEqU1aJEaxvdDGflpj5j+ +TfLOzKoDWPCfFYkvNpfRCoyqntj/38S8dFTMifKIoF6DFU9jHzcNXaIimeFUjkj 9U6gx2pMN9ozJKpaYYvRfIqwVPwWHHKNxvRIGR5sxgCuInnRy3Ktpo3jhe9sNnQ= =k5yx -----END PGP SIGNATURE----- --=-BouWE21Qm1oMmFFJONMr--