From owner-svn-src-all@FreeBSD.ORG Sun Mar 7 20:10:34 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BCCF1065673; Sun, 7 Mar 2010 20:10:34 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id A12B58FC17; Sun, 7 Mar 2010 20:10:33 +0000 (UTC) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.3/8.14.3) with ESMTP id o27KATLE051761; Sun, 7 Mar 2010 23:10:29 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1267992630; bh=dcQkSswHT9yWEkPVrJ2lZ9mPNhw8KKorT5NtKKkHH3E=; l=728; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=Lgr8hIuJ3TO7+QOFA3ZddRenjybCV1z40cK68ZgCLdSSJKM0dQDiAq27OdD3MY6RB A3Qor63FhX4gSY8xIW0iGhlR/6eqKpaKX8/ElYVKL4dU32b30W5njbZToed254ZrkH geSuP7fYtenpQTNCInTkmnPN97u9qrBvmzls7+U0= Received: (from ache@localhost) by nagual.pp.ru (8.14.3/8.14.3/Submit) id o27KASwW051760; Sun, 7 Mar 2010 23:10:29 +0300 (MSK) (envelope-from ache) Date: Sun, 7 Mar 2010 23:10:27 +0300 From: Andrey Chernov To: Bruce Evans , Jaakko Heinonen , src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG Message-ID: <20100307201027.GA51623@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Bruce Evans , Jaakko Heinonen , src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG References: <201003061921.o26JLv36014114@svn.freebsd.org> <20100307104626.GA9015@a91-153-117-195.elisa-laajakaista.fi> <20100308015926.O11669@delplex.bde.org> <20100307183139.GA50243@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100307183139.GA50243@nagual.pp.ru> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Subject: Re: svn commit: r204803 - head/usr.bin/uniq X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Mar 2010 20:10:34 -0000 On Sun, Mar 07, 2010 at 09:31:39PM +0300, Andrey Chernov wrote: > It is right idea. I'll use sysconf(__SC_LINE_MAX) there. > But currently it does the same (sysconf.c): > case _SC_LINE_MAX: > return (LINE_MAX); ... > To add more: > NetBSD uniq grows (contrary, NetBSD comm silently discarding everything > afterwards). > OpenBSD uniq just use fgets with 8192. > GNU uniq grows. After thinking a bit more I consider to reimplement unlimited lines here instead because enforcing POSIX limit was not the main goal of my commit (it was to remove getwc() which is evil). Someone may deal with the limit on his own way afterwards. Will be in the next commit. -- http://ache.pp.ru/