From owner-svn-src-head@freebsd.org  Thu Jan 14 20:57:21 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABF54A8244F;
 Thu, 14 Jan 2016 20:57:21 +0000 (UTC)
 (envelope-from nwhitehorn@freebsd.org)
Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9B9101239;
 Thu, 14 Jan 2016 20:57:21 +0000 (UTC)
 (envelope-from nwhitehorn@freebsd.org)
Received: from aurora.physics.berkeley.edu (aurora.physics.berkeley.edu
 [128.32.117.67]) (authenticated bits=0)
 by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id u0EKvICn024243
 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
 Thu, 14 Jan 2016 12:57:19 -0800
Subject: Re: svn commit: r294029 - in head/sys/boot/efi: . boot1 loader
To: Steven Hartland <smh@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201601141853.u0EIrshB007863@repo.freebsd.org>
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
Message-ID: <56980BAE.6070304@freebsd.org>
Date: Thu, 14 Jan 2016 12:57:18 -0800
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <201601141853.u0EIrshB007863@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Sonic-CAuth: UmFuZG9tSVZZg43Id3JBTzJW7bjd4yZ3hKYDHINE94990ynZix+BrIwYBdix1JbbvHZNZyh0typtgTLnfy9xeP2YkfrL49m/pX2grTe31v4=
X-Sonic-ID: C;0BozZgG75RG/IvA4AoajKQ== M;JAhlZgG75RG/IvA4AoajKQ==
X-Spam-Flag: No
X-Sonic-Spam-Details: 0.0/5.0 by cerberusd
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 20:57:21 -0000



On 01/14/16 10:53, Steven Hartland wrote:
> Author: smh
> Date: Thu Jan 14 18:53:54 2016
> New Revision: 294029
> URL: https://svnweb.freebsd.org/changeset/base/294029
>
> Log:
>    Only build EFI components on supported compilers
>    
>    As the in-tree GCC does not support __attribute__((ms_abi)) EFI can only
>    be built with Clang.
>    
>    The EFI loader and boot1 validated this, but unused libefi was still built
>    causing issues under GCC after warnings where enabled by r293724.
>    
>    Disable building all of EFI when the selected compiler is GCC.
>    

How about with newer-than-4.2 versions of GCC? Surely this *is* 
supported in newer compilers. Do we need some build infrastructure to 
how about the compiler version as well as type?
-Nathan