From nobody Sun Jul 6 20:47:27 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bZzvh1dQzz61lkV; Sun, 06 Jul 2025 20:47:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bZzvh0W9zz3XrK; Sun, 06 Jul 2025 20:47:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751834848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uZmGYTDDN5CqN6D1U6NlDFThU5QJTLQ9V/aLRB5x9G4=; b=S99KkKPFrtLpljaRDf3nrUO69icZnJNyYDVMHA4awNCGyo/euB6heYDkuS3zgy0TmrysDS NoyVLh/mrEn7QSQk8h//r1tUrF+gYOqJ4NdgC+cLP85nMW0+7C9AxAmWcyyVR7IAUGNQpS D0qZPSDruTWoIsWNeNxWsSwEhHCvjIXr1DPe9xSHvdben+Yn3ie11y/rsXOo+xNFo+a17/ Kd80c95+WzkHvtswVkif5Dve/xN0CcFxfK09oTK06Cs3OU0X5atWmbpLHNpHu18Uvvo6tq afWJujkQv5D3g5pXUTKTf6nxR8Iz8s4lGHPiw1rYryqeSvS4Okmn/RprmE1nkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751834848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uZmGYTDDN5CqN6D1U6NlDFThU5QJTLQ9V/aLRB5x9G4=; b=jvkwTYiYnCA6aCBtjoDP22cMxrlHPBGqxf1oXgwg3O1pw0ws0kQruewD/LhwvFYDY3Y/x4 v5kZRZ8qtX9+9Pp4DaEvi4pxJOymqSSx0JRtDeAoj8axqLtyThxydinaLA2A7SEKZZiUeL CwwyQU0NIfC7+9QBxPD9f8N6bFyk/MK1WElQLfKkCbUHQ4cVOXHdEAGASFqOL9e4gYCGuh hV6EaFMWEyVJjkE3era/fu40xvZVyF/uw2U611OdYSZJwRDQZSogvE7x5K99GxfDAk8MC+ R25NDDfIc+LHTbcdt4AHYyVAGIxwheUJOVQs6iPCUEtcE/Cey7/bl2jIRplFPw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751834848; a=rsa-sha256; cv=none; b=al1DfiVK0xhMApACtqYkcNLXpkz2QGC1H+HWhCZNisYbgLuUyp4PTMfnUrZ2UNU/6MosfG tlM1j/pfxllmXJ65JkIRpY0alK3I7hcg9huAwePYWXFSIrV30Ls/ElzXSEYx6GMtaoVULR M0Hn7MXN8ZRtUNJt8kNo202/J4du3YNzz57/Mue3mryHBpIJPohbnUUtPkENft0oswfAFq GqO2zspHX7eBI/5bUv/6RDfUuv94pVsYSPsvbSnvzJHV7HIaODcrBFUoN2GhiiBCuVcFE2 8a+Xw/u33OZnlRZ83RDg2E9iyNJol0mO3B00d9FwMyL79OOCjzg9Ao7p4JJ0fA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bZzvg6y93z55v; Sun, 06 Jul 2025 20:47:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 566KlR6m046626; Sun, 6 Jul 2025 20:47:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 566KlRUl046623; Sun, 6 Jul 2025 20:47:27 GMT (envelope-from git) Date: Sun, 6 Jul 2025 20:47:27 GMT Message-Id: <202507062047.566KlRUl046623@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Doug Moore Subject: git: 2d6185cf87e8 - main - vm_fault: drop never-true busy_sleep test List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2d6185cf87e815d4951a9ddcf5c535ebd07a8815 Auto-Submitted: auto-generated The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=2d6185cf87e815d4951a9ddcf5c535ebd07a8815 commit 2d6185cf87e815d4951a9ddcf5c535ebd07a8815 Author: Doug Moore AuthorDate: 2025-07-06 20:46:00 +0000 Commit: Doug Moore CommitDate: 2025-07-06 20:46:00 +0000 vm_fault: drop never-true busy_sleep test vm_fault_busy_sleep() tests to see whether the page fs->m matches the value looked up at fs->pindex. At that point, a lock is held on fs->object, and it has been held since before vm_fault_object() also looked up fs->pindex in fs->object and stored the result in fs->m. So the values must match, and the test is not necessary. Drop it. Reviewed by: alc, markj Differential Revision: https://reviews.freebsd.org/D51179 --- sys/vm/vm_fault.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c index 21584abacfa3..3e57e8d4f1d0 100644 --- a/sys/vm/vm_fault.c +++ b/sys/vm/vm_fault.c @@ -1441,8 +1441,7 @@ vm_fault_busy_sleep(struct faultstate *fs) } vm_object_pip_wakeup(fs->object); vm_fault_unlock_map(fs); - if (fs->m != vm_page_lookup(fs->object, fs->pindex) || - !vm_page_busy_sleep(fs->m, "vmpfw", 0)) + if (!vm_page_busy_sleep(fs->m, "vmpfw", 0)) VM_OBJECT_UNLOCK(fs->object); VM_CNT_INC(v_intrans); vm_object_deallocate(fs->first_object);