From owner-svn-src-all@FreeBSD.ORG  Sun Aug  8 21:41:59 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B38271065673;
	Sun,  8 Aug 2010 21:41:59 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 71CAA8FC1D;
	Sun,  8 Aug 2010 21:41:59 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o78LZYZX046519;
	Sun, 8 Aug 2010 15:35:34 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Sun, 08 Aug 2010 15:36:08 -0600 (MDT)
Message-Id: <20100808.153608.1142818667055052395.imp@bsdimp.com>
To: olli@fromme.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <201008082037.o78KbLDt022321@haluter.fromme.com>
References: <20100807.205058.260300877050427878.imp@bsdimp.com>
	<201008082037.o78KbLDt022321@haluter.fromme.com>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, olli@FreeBSD.org
Subject: Re: svn commit: r211023 - head/usr.sbin/syslogd
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Aug 2010 21:41:59 -0000

In message: <201008082037.o78KbLDt022321@haluter.fromme.com>
            Oliver Fromme <olli@fromme.com> writes:
: 
: M. Warner Losh wrote:
:  > In message: <201008071620.o77GKDBb091327@svn.freebsd.org>
:  >             Oliver Fromme <olli@FreeBSD.org> writes:
:  > : Author: olli
:  > : Date: Sat Aug  7 16:20:12 2010
:  > : New Revision: 211023
:  > : URL: http://svn.freebsd.org/changeset/base/211023
:  > : Modified: head/usr.sbin/syslogd/Makefile
:  > : ==============================================================================
:  > : --- head/usr.sbin/syslogd/Makefile	Sat Aug  7 16:14:40 2010	(r211022)
:  > : +++ head/usr.sbin/syslogd/Makefile	Sat Aug  7 16:20:12 2010	(r211023)
:  > : @@ -12,7 +12,7 @@ SRCS=	syslogd.c ttymsg.c
:  > :  DPADD=	${LIBUTIL}
:  > :  LDADD=	-lutil
:  > :  
:  > : -WARNS?=	3
:  > : +WARNS?=	6
:  > :  
:  > :  .if ${MK_INET6_SUPPORT} != "no"
:  > :  CFLAGS+= -DINET6
:  > 
:  > This breaks MIPS, so I've reverted it.  Please make sure that all
:  > architectures work when bumping up WARNS.
: 
: Thanks for fixing it for me.
: 
: I did make the universe check, but apparently I did something
: wrong, so I didn't notice the problem.  I'm sorry for that.

The casting that syslogd does with struct sockaddrFOO is what triggers
it.  I'm not sure how to fix it, so there's about 6 or 8 programs in
the tree that have WARNS lowered to 3 because of it.

Warner