Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Jun 2016 09:59:27 +0000 (UTC)
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r417821 - head/Mk/Scripts
Message-ID:  <201606300959.u5U9xRJI080025@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mat
Date: Thu Jun 30 09:59:27 2016
New Revision: 417821
URL: https://svnweb.freebsd.org/changeset/ports/417821

Log:
  Only warn about symlinks that exist in the stage directory, or that
  exist nowhere.
  
  Sponsored by:	Absolight

Modified:
  head/Mk/Scripts/qa.sh   (contents, props changed)

Modified: head/Mk/Scripts/qa.sh
==============================================================================
--- head/Mk/Scripts/qa.sh	Thu Jun 30 09:55:18 2016	(r417820)
+++ head/Mk/Scripts/qa.sh	Thu Jun 30 09:59:27 2016	(r417821)
@@ -144,7 +144,14 @@ symlinks() {
 				rc=1
 				;;
 			/*)
-				warn "Bad symlink '${l#${STAGEDIR}}' pointing to an absolute pathname '${link}'"
+				# Only warn for symlinks within the package.
+				if [ -e "${STAGEDIR}${link}" ]; then
+					warn "Bad symlink '${l#${STAGEDIR}}' pointing to an absolute pathname '${link}'"
+				fi
+				# Also warn if the symlink exists nowhere.
+				if [ ! -e "${STAGEDIR}${link}" -a ! -e "${link}" ]; then
+					warn "Symlink '${l#${STAGEDIR}}' pointing to '${link}' which does not exist in the stage directory or in localbase"
+				fi
 				;;
 		esac
 	# Use heredoc to avoid losing rc from find|while subshell.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201606300959.u5U9xRJI080025>