From owner-svn-src-head@FreeBSD.ORG Wed Apr 1 23:07:40 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D98B256B; Wed, 1 Apr 2015 23:07:40 +0000 (UTC) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6324FA2A; Wed, 1 Apr 2015 23:07:39 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id BF53725D3AF8; Wed, 1 Apr 2015 23:07:30 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 1AA16C76FDC; Wed, 1 Apr 2015 23:07:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id Rw-SM_SKdh1s; Wed, 1 Apr 2015 23:07:28 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:9493:5ffd:7abc:91bb] (unknown [IPv6:fde9:577b:c1a9:4410:9493:5ffd:7abc:91bb]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 46D49C76FD3; Wed, 1 Apr 2015 23:07:27 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r280971 - in head: contrib/ipfilter/tools share/man/man4 sys/contrib/ipfilter/netinet sys/netinet sys/netipsec sys/netpfil/pf From: "Bjoern A. Zeeb" In-Reply-To: <201504012226.t31MQedN044443@svn.freebsd.org> Date: Wed, 1 Apr 2015 23:06:54 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <78B754F0-60D9-4E75-84B5-C260094AAFD0@FreeBSD.org> References: <201504012226.t31MQedN044443@svn.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 23:07:41 -0000 > On 01 Apr 2015, at 22:26 , Gleb Smirnoff wrote: >=20 > Author: glebius > Date: Wed Apr 1 22:26:39 2015 > New Revision: 280971 > URL: https://svnweb.freebsd.org/changeset/base/280971 >=20 > Log: > o Use new function ip_fillid() in all places throughout the kernel, > where we want to create a new IP datagram. > o Add support for RFC6864, which allows to set IP ID for atomic IP > datagrams to any value, to improve performance. The behaviour is > controlled by net.inet.ip.rfc6864 sysctl knob, which is enabled by > default. > o In case if we generate IP ID, use counter(9) to improve = performance. > o Gather all code related to IP ID into ip_id.c. >=20 > Differential Revision: = https://reviews.freebsd.org/D2177 > Reviewed by: adrian, cy, rpaulo > Tested by: Emeric POUPON > Sponsored by: Netflix > Sponsored by: Nginx, Inc. > Relnotes: yes >=20 breaks build, e.g. sparc64 generic-nodebug: /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: data = definition has no type or storage class /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: type defaults = to 'int' in declaration of 'SYSINIT' /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: parameter = names (without types) in function declaration /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: data = definition has no type or storage class /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: type defaults = to 'int' in declaration of 'SYSUNINIT' /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107: warning: parameter = names (without types) in function declaration /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:269: error: expected ')' = before '(' token /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:282: error: expected =E2=80=98= )' before '(' token i386 GENERIC has more info =E2=80=A6 07:8: error: type specifier missing, defaults to 'int' = [-Werror,-Wimplicit-int] static MALLOC_DEFINE(M_IPID, "ipid", "randomized ip id state"); ^ /scratch/tmp/bz/head.svn/sys/sys/malloc.h:137:2: note: expanded from = macro 'MALLOC_DEFINE' SYSINIT(type##_init, SI_SUB_KMEM, SI_ORDER_THIRD, malloc_init, = \ ^ /scratch/tmp/bz/head.svn/sys/netinet/ip_id.c:107:8: error: a parameter = list without types is only allowed in a function definition /scratch/tmp/bz/head.svn/sys/sys/malloc.h:137:10: note: expanded from = macro 'MALLOC_DEFINE' SYSINIT(type##_init, SI_SUB_KMEM, SI_ORDER_THIRD, malloc_init, = \ ^ :235:1: note: expanded from here M_IPID_init ^ > Modified: > head/contrib/ipfilter/tools/ipftest.c > head/share/man/man4/inet.4 > head/sys/contrib/ipfilter/netinet/fil.c > head/sys/contrib/ipfilter/netinet/ip_fil.h > head/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c > head/sys/contrib/ipfilter/netinet/ip_nat.c > head/sys/netinet/ip_carp.c > head/sys/netinet/ip_gre.c > head/sys/netinet/ip_id.c > head/sys/netinet/ip_input.c > head/sys/netinet/ip_mroute.c > head/sys/netinet/ip_output.c > head/sys/netinet/ip_var.h > head/sys/netinet/raw_ip.c > head/sys/netinet/sctp_output.c > head/sys/netipsec/xform_ipip.c > head/sys/netpfil/pf/if_pfsync.c > head/sys/netpfil/pf/pf_norm.c =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."