From owner-svn-src-head@freebsd.org Fri Jan 26 10:14:20 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2933AECDCCE; Fri, 26 Jan 2018 10:14:20 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 45D7E6C8EB; Fri, 26 Jan 2018 10:14:18 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 6f1b35c4; Fri, 26 Jan 2018 11:14:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=954JvhhrlE4gJsNgQsRE8fdsTsw=; b=j0h2pE+YohIwkT/gLEg1/2ZjrLum 1gG8MJkibdYzu1/Fpn3yto4chgEddk9rFNwRW+eX/QZITmNy8F+tpqPZoYB5Lm1F oqUOS6e6LV1V6Ige+scXf3SyKiktCL8AKt4nINN6lvvr/lCvU2eWz6HxpE7gMWEZ 8sDplMAu3ZWgHwY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=EF5rJhglMLwlPihWY3IADyQZmu7YjnqwLBap0nOEVPQLP9V+43ComKj7 LrMqzshqDibdsnSR9NmOVDpjXX7DL5FFRDJKhZzWFLZVEydtY3OuIf03gQrKsUGC EA8tUfIhol9NOIQ5OEXQktcnLuijrcYspo3186uXNZpIGLyqVQw= Received: from arcadia (evadot.gandi.net [217.70.181.36]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 33995fbd TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 26 Jan 2018 11:14:16 +0100 (CET) Date: Fri, 26 Jan 2018 11:14:16 +0100 From: Emmanuel Vadot To: Ruslan Bukin Cc: Ruslan Bukin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328402 - head/sys/dev/usb/controller Message-Id: <20180126111416.21d99403b0ff40c06d610990@bidouilliste.com> In-Reply-To: <20180125171452.GA61523@bsdpad.com> References: <201801251658.w0PGwNcq058492@repo.freebsd.org> <20180125181204.bb006fbb3a9bcd4acb4236af@bidouilliste.com> <20180125171452.GA61523@bsdpad.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 10:14:20 -0000 On Thu, 25 Jan 2018 17:14:52 +0000 Ruslan Bukin wrote: > On Thu, Jan 25, 2018 at 06:12:04PM +0100, Emmanuel Vadot wrote: > > > Log: > > > Add basic driver for Qualcomm USB 2.0 EHCI controller. > > > This driver relies on system initialization in u-boot. > > > > > > Tested on DragonBoard 410c. > > > > > > Sponsored by: DARPA, AFRL > > > > > > Added: > > > head/sys/dev/usb/controller/ehci_msm.c (contents, props changed) > > > > > > > The code looks like the generic-ehci, would it be better to subclass > > generic-ehci to fdt and add qualcomm quirks if necessary ? > > > > Hi Emmanuel > > This driver is incomplete currently and requires initialization in u-boot. > > Both system clocks and EHCI subsystem, also Qualcomm power management device requires full initialization. > My goal will be to extend this driver and proceed full initialization required for Qualcomm EHCI. Yes I can see that all the clock/reset/phy management is not yet done. But the generic-ehci driver should be subclassed so you can re-use the ehdi generic code in your driver. Then you will just need the attach function to deal the clock/reset/phy. > The u-boot option CONFIG_DM_DEVICE_REMOVE=n must be added in order to keep devices initialized before jumping to FreeBSD. We will need to get rid of these by adding some code to this driver I guess. > > Thanks. > > Ruslan -- Emmanuel Vadot