Date: Thu, 29 Aug 2019 19:44:59 -0400 From: Ed Maste <emaste@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org>, fcp@freebsd.org Subject: Re: FCP 20190401-ci_policy: CI policy Message-ID: <CAPyFy2Dig7MF=NcDWqT=qSTeS_qh1PhRr=hSC_LfHa2X6jU0jg@mail.gmail.com> In-Reply-To: <CANCZdfqpzoR2YE0H493xTgfOxXcoSOJKrO9CWoc7KNaAk5BvHQ@mail.gmail.com> References: <CAOfEmZgEbT7ni80vWehHm%2B4oPyH3m%2Brb0M_VyxHmNM3rkhyG1Q@mail.gmail.com> <201908291905.x7TJ5Bw8091371@gndrsh.dnsmgr.net> <CANCZdfoYNn9Xcyds_YbDXMLTrMdmTewvP_pK7FSDAPbDAeV6Lw@mail.gmail.com> <CANCZdfqagrUzv5wOawypu55Naxt9%2BAHLSege4ccEzrDkuFa9Mg@mail.gmail.com> <CAPyFy2BH2EN-KCWhtNku8BghnguEVXr=F04=H51_YdPCNPnhUA@mail.gmail.com> <CANCZdfqpzoR2YE0H493xTgfOxXcoSOJKrO9CWoc7KNaAk5BvHQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>> This sounds more like a problem with the tooling than an argument >> against reverting though. > > We live in a subversion universe for the moment, so you have to view it t= hrough that lens. Fair enough, right now the policy needs to accommodate the reality of the tools we're using today. Perhaps it's a failure of imagination on my part but I have trouble seeing how a revert would lead to losing work - could you give an example? > Sometimes yes, sometimes no. Even with git svn, there is a cost associate= d with it. The level of effort is not zero. Especially when one pushes sev= eral interrelated changes at once. If the first of these caused an issue on= gcc, say, often the cost is too high to revert the whole chain. It's a lot= easier to put in a fix and move on. The level of effort imposed on other users while the tree is broken is not zero, either. Certainly if it's possible to commit a fix and move forward that's the approach favoured by community norms. > It's a fair example for why a simpleminded approach will create more fric= tion than the current system. And there is a need for caution in expanding = the logic beyond all but the most recent changes... The point of the FCP is to facilitate the revert while the change is (among the) most recent, precisely so that additional changes don't build on it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Dig7MF=NcDWqT=qSTeS_qh1PhRr=hSC_LfHa2X6jU0jg>