Date: Thu, 04 Sep 2014 14:28:30 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 191562] [new port] sysutils/rundeck Rundeck - remote node orchestration server Message-ID: <bug-191562-13-s6dBOhPeAr@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-191562-13@https.bugs.freebsd.org/bugzilla/> References: <bug-191562-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D191562 --- Comment #10 from arcade@b1t.name --- (In reply to John Marino from comment #9) > Issue 1) Please respect 80-column limits. Use "\" to wrap lines. I see a > couple of places this is needed. fixed > Issue 2) regarding this code: >=20 > +.include <bsd.port.pre.mk> > + > +do-install: > + ${MKDIR} ${STAGEDIR}${DATADIR} ${STAGEDIR}${RUNDECK_HOME}/server/lib > + ${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/${DISTNAME}${EXTRACT_SUFX} > ${STAGEDIR}${DATADIR}/${PORTNAME}-launcher${EXTRACT_SUFX} > + > +.include <bsd.port.post.mk> >=20 >=20 > Question 2A) Why is <pre> and <post> needed here? How do I know? :) I just ripped that part from jenkins port. I suppose there were some variables used that were defined at <pre> step. fixed > Request 2B) Please replace ${PORTNAME} with "rundeck". If I changed the > name the port, the do-install would break. I know that *TONS* of people = do > exactly this and I think it's outright wrong. fixed I also updated port to 2.2.1. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191562-13-s6dBOhPeAr>