From owner-p4-projects@FreeBSD.ORG  Fri Dec 28 23:40:15 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0099016A421; Fri, 28 Dec 2007 23:40:15 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B978F16A419;
	Fri, 28 Dec 2007 23:40:14 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id A345913C442;
	Fri, 28 Dec 2007 23:40:14 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id lBSNYRHp078612;
	Fri, 28 Dec 2007 16:34:27 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 28 Dec 2007 16:39:17 -0700 (MST)
Message-Id: <20071228.163917.-169064562.imp@bsdimp.com>
To: hselasky@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200712282257.lBSMvPQi030689@repoman.freebsd.org>
References: <200712282257.lBSMvPQi030689@repoman.freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 131926 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Dec 2007 23:40:15 -0000

In message: <200712282257.lBSMvPQi030689@repoman.freebsd.org>
            Hans Petter Selasky <hselasky@freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=131926
: 
: Change 131926 by hselasky@hselasky_laptop001 on 2007/12/28 22:56:35
: 
: 	
: 	Looks like the wrong mask is used. Not sure if it
: 	has any practical effect. Please correct me if this
: 	patch is wrong. At least the OHCI and AT91 UDP works
: 	regardless of this patch.

I think this is right.  It works because we force the pmc mask to
0xffffffff elsewhere.

Warner

: Affected files ...
: 
: .. //depot/projects/usb/src/sys/arm/at91/at91_pmc.c#5 edit
: 
: Differences ...
: 
: ==== //depot/projects/usb/src/sys/arm/at91/at91_pmc.c#5 (text) ====
: 
: @@ -128,7 +128,7 @@
:  static struct at91_pmc_clock ohci_clk = {
:  	.name = "ohci_clk",
:  	.parent = &mck,
: -	.pmc_mask = 1 << AT91RM92_IRQ_UDP,
: +	.pmc_mask = 1 << AT91RM92_IRQ_UHP,
:  	.set_mode = &at91_pmc_set_periph_mode
:  };