Date: Fri, 28 Dec 2007 16:39:17 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: hselasky@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 131926 for review Message-ID: <20071228.163917.-169064562.imp@bsdimp.com> In-Reply-To: <200712282257.lBSMvPQi030689@repoman.freebsd.org> References: <200712282257.lBSMvPQi030689@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200712282257.lBSMvPQi030689@repoman.freebsd.org>
Hans Petter Selasky <hselasky@freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=131926
:
: Change 131926 by hselasky@hselasky_laptop001 on 2007/12/28 22:56:35
:
:
: Looks like the wrong mask is used. Not sure if it
: has any practical effect. Please correct me if this
: patch is wrong. At least the OHCI and AT91 UDP works
: regardless of this patch.
I think this is right. It works because we force the pmc mask to
0xffffffff elsewhere.
Warner
: Affected files ...
:
: .. //depot/projects/usb/src/sys/arm/at91/at91_pmc.c#5 edit
:
: Differences ...
:
: ==== //depot/projects/usb/src/sys/arm/at91/at91_pmc.c#5 (text) ====
:
: @@ -128,7 +128,7 @@
: static struct at91_pmc_clock ohci_clk = {
: .name = "ohci_clk",
: .parent = &mck,
: - .pmc_mask = 1 << AT91RM92_IRQ_UDP,
: + .pmc_mask = 1 << AT91RM92_IRQ_UHP,
: .set_mode = &at91_pmc_set_periph_mode
: };
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071228.163917.-169064562.imp>