From owner-cvs-all@FreeBSD.ORG Fri Dec 31 11:12:19 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22A4716A4CE; Fri, 31 Dec 2004 11:12:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E2EC43D3F; Fri, 31 Dec 2004 11:12:19 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iBVBCIdB094077; Fri, 31 Dec 2004 11:12:18 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iBVBCIAU094076; Fri, 31 Dec 2004 11:12:18 GMT (envelope-from kensmith) Message-Id: <200412311112.iBVBCIAU094076@repoman.freebsd.org> From: Ken Smith Date: Fri, 31 Dec 2004 11:12:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/vm vm_map.c vm_object.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Dec 2004 11:12:19 -0000 kensmith 2004-12-31 11:12:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/vm vm_map.c vm_object.c Log: MFC of rev 1.329 of vm_object.c: date: 2004/07/28 18:23:08; author: alc; state: Exp; lines: +2 -2 Correct a very old error in both vm_object_madvise() (originating in vm/vm_object.c revision 1.88) and vm_object_sync() (originating in vm/vm_map.c revision 1.36): When descending a chain of backing objects, both use the wrong object's backing offset. Consequently, both may operate on the wrong pages. Quoting Matt, "This could be responsible for all of the sporatic madvise oddness that has been reported over the years." Reviewed by: Matt Dillon Reviewed by: alc Helped by: DFly vm_map.c rev 1.31, vm_object.c rev 1.17 Revision Changes Path 1.187.2.32 +1 -1 src/sys/vm/vm_map.c 1.171.2.10 +2 -2 src/sys/vm/vm_object.c