From owner-svn-src-all@freebsd.org Thu Mar 7 00:03:02 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79A2D152C0D6; Thu, 7 Mar 2019 00:03:02 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0771B77F7A; Thu, 7 Mar 2019 00:03:01 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x2702x0g088190; Wed, 6 Mar 2019 16:02:59 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x2702xQX088189; Wed, 6 Mar 2019 16:02:59 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903070002.x2702xQX088189@ gndrsh.dnsmgr.net> Subject: Re: svn commit: r344859 - in head: sbin/ifconfig sys/net sys/netinet6 In-Reply-To: To: "Bjoern A. Zeeb" Date: Wed, 6 Mar 2019 16:02:59 -0800 (PST) CC: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Reply-To: rgrimes@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 0771B77F7A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 00:03:02 -0000 > On 6 Mar 2019, at 23:39, Rodney W. Grimes wrote: > > >> Author: bz > >> Date: Wed Mar 6 23:31:42 2019 > >> New Revision: 344859 > >> URL: https://svnweb.freebsd.org/changeset/base/344859 > >> > >> Log: > >> Update for IETF draft-ietf-6man-ipv6only-flag. > >> > >> All changes are hidden behind the EXPERIMENTAL option and are not > >> compiled > >> in by default. > > > > It is probably time to make EXPERIMENTAL finer grain, > > there are likely more than one experiment to be avaliable > > in the tree at the same time, and having them all use this > > one knob is a bit of a pita. > > I added the knob to encourage people putting more stuff under it. Such as? > Making it finer grained did not seem to be a good idea at the time. > For that we do have individual kernel options. Which is what I am going to have to do for my "EXPERIMENT" since I do not want this code in it. Its fine, but more or less you have now reserved EXPERIMENT for some subset, and I'll call mine something like EXPERIMENT_foo > If you are saying that I should add an extra layer of #ifdef under > EXPERIMENTAL such as #ifdef EXP_IPV6_ONLY_FLAG, adding such a kernel > option seems plausible though a pain when this either goes away entirely > or becomes mainline and in either case would not be under an extra > option. I would of just used #ifdef EXP_IPV6_ONLY_FLAG and not used EXPERIMENTAL at all. The #ifdef goes away when it is mainline. > /bz -- Rod Grimes rgrimes@freebsd.org