From nobody Fri Jun 27 19:37:52 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTQnb5kThz609d3; Fri, 27 Jun 2025 19:37:55 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTQnb538zz3pBk; Fri, 27 Jun 2025 19:37:55 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751053075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N3DW/SB3YYxRFYVZGlI3XZ5ySrZNXSjPP0dpSxHtHZY=; b=BaA2eAtXErXPShqv67TgA2wDsmkiDy96DYYsgK8h/gpaBI2VfAUEqyQCBAvFjYiPtKEOjI AanZw9l97JkJwSxyyXWLPAWHEJu1y35v7grxKt7CMidH+k1fPh9OtKUsnD83GW9RtwzaSP fNDcyFRwA7OgRu4UCEwHUyZT+FmVEjkkdCA2i7gO71i3yw+TfIKifDoAMCkU8XjokRwZOz gGc1yNXOMz/VSPDSvjBLFIRth0KRqvSZqDd60jLzRFgn27FA8I00AVygB1GG1ckisYlDaf FKSf5Qg+6AqgmD+NTAqqsF0Q/fQJaHBMMd1oJf1uFnUFkXLkN1IdbJR93lRo5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751053075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N3DW/SB3YYxRFYVZGlI3XZ5ySrZNXSjPP0dpSxHtHZY=; b=sJEORknBOcm/Ehx0ZOyM6Puk/MGaPcOB35HZ6aUwl0wKDXLsIHn0otDuYEj/n6TYGMDayZ Sw64RyMm0Jt+SPAallDX7WWE3iikzVdaSJEMXGnlbu2RYzcaOrjpdv+7DssGxA5FkVRmg0 JAiwu1zyfO/eYY1Dtj42JwunJuz42Ql6XLf1NT8iJrXFQtg5WcXljDrRJuOuVmI0Yu7PdD IIHTonL45czAfV0zn8VzzmHZ++/elYODf0zeXeSdQJ9pu0+l0AAzh6867SvW20Cj4Qx0XM igeaMxiwxWtQ46eHjZWPITaPRw2xiiQ8h09Z+E4FNL4tvhlR4u3AHlNzzUE/aQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751053075; a=rsa-sha256; cv=none; b=tJYEhK1zWw9MGl6WEm0qJClsRWl1y94io3J9GJ8WsIip2AHSIUfPFwpL9K5FgfG81dnEH6 GgBUGAyMThe3h0OavfmJ5iLYJwMOitWjnyel9WmXIt7GUALdFjD1SMshxXBOBqh/2UlQGC jnBp/hNw6+aV/DzCxpQoln/pIsTPwjLmFffe0RSE6HVcHuRZ4TD0QzcXGOdD31aw8Ynf01 Y57eJORjfNqnL6h29m86nd3KV/LNHZbyTFHrBneoEo9Dxg82LhlD2vwJ0gV3bH134u//ik ikwZhQdEPcMw0dG4RxEsN9aiQ0gEAPzW+mm7iYjK9qAi3slZfpWVGYpb4BG4+A== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bTQnZ5KR3zDHQ; Fri, 27 Jun 2025 19:37:54 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 27 Jun 2025 12:37:52 -0700 From: Gleb Smirnoff To: Baptiste Daroussin Cc: Mark Johnston , Hiroki Sato , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, srcmgr@freebsd.org Subject: Re: git: 4deb9760a9d8 - main - rc: Disable pathname expansion when calling run_rc_command() Message-ID: References: <202506121820.55CIKQTQ097365@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 27, 2025 at 08:56:23PM +0200, Baptiste Daroussin wrote: B> On Wed 18 Jun 10:13, Mark Johnston wrote: B> > On Thu, Jun 12, 2025 at 06:20:26PM +0000, Hiroki Sato wrote: B> > > The branch main has been updated by hrs: B> > > B> > > URL: https://cgit.FreeBSD.org/src/commit/?id=4deb9760a9d84d5861ee45162ffebe83f13503b8 B> > > B> > > commit 4deb9760a9d84d5861ee45162ffebe83f13503b8 B> > > Author: Hiroki Sato B> > > AuthorDate: 2025-06-12 18:19:32 +0000 B> > > Commit: Hiroki Sato B> > > CommitDate: 2025-06-12 18:19:32 +0000 B> > > B> > > rc: Disable pathname expansion when calling run_rc_command() B> > > B> > > Variables for command-line options like $foo_flags can contain characters B> > > that perform pathname expansions, such as '[', ']', and '*'. They were B> > > passed without escaping, and the matched entries in the working directory B> > > affected the command-line options. This change turns off the expansion B> > > when run_rc_command() is called. B> > > B> > > While this changes the current behavior, an invocation of a service B> > > program should not depend on entries in the working directory. B> > B> > This also turns off globbing for /etc/rc.local, which broke one of my B> > scripts. Was that intentional? If so, we should really document it in B> > RELNOTES at the very least. B> B> This broke nuageinit which rely on globbing to in nuageinit_start, that this B> change also broke. B> B> So many downstream CI are now broken, due to this change. Given that Hiroki is not reacting on this email thread neither in https://reviews.freebsd.org/D51043, I would like to revert this change. I'd like also remind that the problem was discovered during the stabweek testing. Although we thawed the freeze, but we are still working on a good known stable revision for June. Any objections? Adding srcmgr@ -- Gleb Smirnoff