From nobody Sun Sep 14 07:35:41 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cPg2L3TqLz67WWL for ; Sun, 14 Sep 2025 07:36:10 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cPg2L1hbjz3jYL for ; Sun, 14 Sep 2025 07:36:10 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-71d60150590so19912267b3.0 for ; Sun, 14 Sep 2025 00:36:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757835369; x=1758440169; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0uubREHrl1i1J/bS6QyQuR5Ay0X2IcsRXtTGMKDded4=; b=WXztQPRGa9SB+gI7wWiFhehUghT/juLus29Ja/goCFGlLawPYYd3Qz1/FbIWdgmNbF HbhygjrFOMQX2R5p5euS7CG//KuYkNJ9Jeism/apP9wQ7xmwCO0gIUlPtkFEJcEohScE SWG3CaUufB8R1JFIM2EX5Gwn25ExgPJKyPqIVKQJsPkjGtOT1A8SKdYkOGw8PCyF53BU uSDqEC4rljFyons7N/Ati2fcopErSCvCwD9HaTCuycC6grRn1MfJAdplSpWCIlHaH5DC XK7EHYViYPk0nz+tnEmEv8yw4DPZSBPCDxtqcK1335or6nD63gSvHcZvIbDVn64tcwrl Npew== X-Forwarded-Encrypted: i=1; AJvYcCWUxOw/Y9KG5oBFe7vdaF9+Hvg7qPeExZ5QLotSp4Mtg8sPIE8ty1K179nKUwoMya0F7HdWbEr8MpRmPkGf4XiO4cl6EA==@freebsd.org X-Gm-Message-State: AOJu0YwF7D8w9HfhrflImOYq0iurDcTiH5wz9Bd2Ux50lISrboy8ebiu QRn57INXirFVIhSj+MX0m2LYAYsZemrPUhpUB3u3MbuuqOw6294plmcmuy00uUhGfW8= X-Gm-Gg: ASbGncs6/5nRor46llNuLSNV2FS5DJMyIIuaEewkZlMqc2d8s6gX1k92Dq5aRI+stTi /wacZpSKGPGqAB0eKmQygQD2lZAi/0n3wxvQhViKfQt88Eq7nhv8oCoBoaGi5k94B7ChaKMAWZy Nhs1L6iUDLMuNeu3BIjuUQ3RkEP5WIi0qjeocioQJ7VxRlK+o3dYmsUk6kZAaOBcufKeikVo3RX 3Vxz95kNssNyYV8WphkQ+HdadL3GHkseUQ3AvN3aj6/q3FqGssMYrZQf/1DzZcF5Gleig5dcvyg MyD2CDBktwXaVUwq7b2hdg5Wgc9zESECRqDXkoPuo07Suxacwk5JCDjLMyxVBtPXpko5T1efKAQ LMj0Goh8Gday4p+14IUf9i5aZ7+2tqz9Pup1R0zx0BsFeOsRn8J2rb+ZtNgW9wCn8hoQPn6mX4h cb2yxI0yw= X-Google-Smtp-Source: AGHT+IHTqCy1biJONLqcpxDTJsAlEYMx8rVcgvcVQJnAYrnReNlRcL3K+EvLRvwmSL0cwpFB8H6Ntw== X-Received: by 2002:a05:690c:6804:b0:72c:bb8e:3d70 with SMTP id 00721157ae682-730659bbd58mr83316667b3.47.1757835369054; Sun, 14 Sep 2025 00:36:09 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id 00721157ae682-72f7969a382sm22880297b3.54.2025.09.14.00.36.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Sep 2025 00:36:08 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-72ce9790ab3so22078607b3.1 for ; Sun, 14 Sep 2025 00:36:08 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWxJP1rTf8GsSi1XvgyBoKgZdvSpRt4a5J1b+M+GtJ3LKhQ/0MjO38JGIS5LpOFPBYR/eBv75pNhRXL6Tgvx2VaKCdo4A==@freebsd.org X-Received: by 2002:a05:690c:2902:b0:722:7a7f:536e with SMTP id 00721157ae682-730633842bemr78298277b3.16.1757835368564; Sun, 14 Sep 2025 00:36:08 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Gleb Popov Date: Sun, 14 Sep 2025 10:35:41 +0300 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwMSJKAYIh4VkWAZMmK9GrGh_IdEa3DwMEG7_hI14ty4Jh7sTxVtynZlM4 Message-ID: Subject: Re: git: fd9e09cb2ab0 - main - kern: replace several EBADF with EINVAL To: Konstantin Belousov Cc: kib@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cPg2L1hbjz3jYL On Sat, Sep 13, 2025 at 10:27=E2=80=AFPM Konstantin Belousov wrote: > > On Sat, Sep 13, 2025 at 09:55:52PM +0300, Gleb Popov wrote: > > This change affects following code inside the Qt library: > > https://github.com/qt/qtbase/blob/d6cc7562689d8a07bc933178ea367706ca38e= 4ac/src/3rdparty/forkfd/forkfd.c#L902 > > > > The code in question expects to receive EBADF when being fed a wrong > > type of the descriptor. Returning EINVAL makes sense to me, so maybe > > we should patch Qt rather than revert this change? > > It is really weird code, calling pdgetpid(2) on random fds. Anyway, plea= se > confirm that the following revert makes the problem go away. It does! > BTW, would it be useful to implement something like waitid(P_PROCDESC) > to eliminate the ugly code you pointed to? >From what I gather, yes. The pdgetpid() call there is only used to obtain a PID to pass to wait4. Having waitid(P_PROCDESC) would save us from calling pdgetpid() > commit 4b47521ce2bc4ede52611c268d00ceb1608d959e > Author: Konstantin Belousov > Date: Sat Sep 13 22:23:27 2025 +0300 > > pdgetpid(2): switch back returning EBADF for non-procdesc fd > > This partially reverts fd9e09cb2ab0, since apparently QT depends on t= his > specific error code. It seems that it applies pdgetpid() to random f= ds > and filters non-procdescs by checking errno for EBADF. > > Reported by: gleb That's a different Gleb, my freefall handle is arrowd. But anyways, the original report came from "Kenneth Raplee ".