From owner-svn-ports-all@freebsd.org  Wed Mar 22 18:27:13 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61ED8D1818D;
 Wed, 22 Mar 2017 18:27:13 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 446CB1D57;
 Wed, 22 Mar 2017 18:27:13 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 970E85F7A; Wed, 22 Mar 2017 18:27:12 +0000 (UTC)
Date: Wed, 22 Mar 2017 18:27:12 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kirill Ponomarew <krion@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r436712 - in head/net/zerotier: . files
Message-ID: <20170322182712.GA96503@FreeBSD.org>
References: <201703221812.v2MICvxf040839@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201703221812.v2MICvxf040839@repo.freebsd.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Mar 2017 18:27:13 -0000

On Wed, Mar 22, 2017 at 06:12:57PM +0000, Kirill Ponomarew wrote:
> New Revision: 436712
> URL: https://svnweb.freebsd.org/changeset/ports/436712
> 
> Log:
>   Update net/zerotier to 1.2.2
>   
>   PR:		217838
>   Submitted by:	dch@skunkwerks.at
>   Approved by:	mat (mentor)
> [...]
>  
> -MAINTAINER=	corsmith@gmail.com
> +MAINTAINER=	dch@skunkwerks.at

This part was not reflected in the log.

> -USES=		gmake
> +USES=		gmake compiler:c11

Nor was this one.

> +GH_ACCOUNT=	zerotier

This is wrong, but I see you've fixed it already.

> -OPTIONS_DEFINE=	CONTROLLER
> -
> -CONTROLLER_DESC=	Network management controller microservice support
> -CONTROLLER_USES=	sqlite
> -CONTROLLER_MAKE_ARGS=	ZT_ENABLE_NETWORK_CONTROLLER=1

Why this part was removed after I've added it just several days ago in
r435612 (see PR 215031)?  If this feature is no longer valid it should
have been reflected in the commit log.  Please do not destroy work of
others without at least giving a sound reason.

./danfe