From owner-p4-projects@FreeBSD.ORG  Wed Mar 14 16:39:09 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D48E816A403; Wed, 14 Mar 2007 16:39:08 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A974C16A400
	for <perforce@FreeBSD.org>; Wed, 14 Mar 2007 16:39:08 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 9692D13C468
	for <perforce@FreeBSD.org>; Wed, 14 Mar 2007 16:39:08 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l2EGd8TY072099
	for <perforce@FreeBSD.org>; Wed, 14 Mar 2007 16:39:08 GMT
	(envelope-from gonzo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l2EGd84H072096
	for perforce@freebsd.org; Wed, 14 Mar 2007 16:39:08 GMT
	(envelope-from gonzo@FreeBSD.org)
Date: Wed, 14 Mar 2007 16:39:08 GMT
Message-Id: <200703141639.l2EGd84H072096@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gonzo@FreeBSD.org using -f
From: Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 115867 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Mar 2007 16:39:09 -0000

http://perforce.freebsd.org/chv.cgi?CH=115867

Change 115867 by gonzo@gonzo_jeeves on 2007/03/14 16:38:47

	o Report real badvaddr instead of aligned to page.
	o Remove extra-space.

Affected files ...

.. //depot/projects/mips2/src/sys/mips/mips/trap.c#16 edit

Differences ...

==== //depot/projects/mips2/src/sys/mips/mips/trap.c#16 (text+ko) ====

@@ -169,7 +169,7 @@
 			pte = pmap_segmap(pmap, va);
 			pte += (va >> PAGE_SHIFT) & (NPTEPG - 1);
 
-			if (pte_ro(pte) )
+			if (pte_ro(pte))
 			{
 				ftype = VM_PROT_WRITE;
 				map = &td->td_proc->p_vmspace->vm_map;
@@ -227,8 +227,8 @@
 			break;
 
 		/* TODO: send signal */
-		printf("Userland memory access error %d on va=%08x, pc=%08x\n",
-		    error, va, tf->tf_regs[TF_EPC]	);
+		printf("Userland memory access error %d on va=%p, pc=%08x\n",
+		    error, badvaddr, tf->tf_regs[TF_EPC]);
 
 		panic("TODO: signal on memory access errors");