From owner-freebsd-gnome@freebsd.org Fri Mar 9 19:13:49 2018 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 849B4F44102 for ; Fri, 9 Mar 2018 19:13:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 010EE87B9B for ; Fri, 9 Mar 2018 19:13:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B1468F440FE; Fri, 9 Mar 2018 19:13:48 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D37CF440FD for ; Fri, 9 Mar 2018 19:13:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2920687B93 for ; Fri, 9 Mar 2018 19:13:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 72C10128EF for ; Fri, 9 Mar 2018 19:13:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w29JDlAD008689 for ; Fri, 9 Mar 2018 19:13:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w29JDlcq008688 for gnome@FreeBSD.org; Fri, 9 Mar 2018 19:13:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 225744] [PATCH] defaulting x11-fonts/fontconfig no-bitmap.conf : [Attachment 191348] Proposed patch (since 463966 revision) Date: Fri, 09 Mar 2018 19:13:46 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 19:13:49 -0000 lightside has asked gnome@FreeBSD.org for maintainer-approval: Bug 225744: [PATCH] defaulting x11-fonts/fontconfig no-bitmap.conf https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225744 Attachment 191348: Proposed patch (since 463966 revision) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D191348&action=3Dedit --- Comment #4 from lightside --- Created attachment 191348 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D191348&action= =3Dedit Proposed patch (since 463966 revision) Hello. I think, possible to create NO_BITMAPS (or with different name) port's opti= on for proposed/committed changes in this PR. Also possible to convert files/patch-conf.d_Makefile.in to sed patch, becau= se of possible dynamic changes to conf.d/Makefile.in file after new version update(s), which may require to fix static patch otherwise. Attched new patch after ports r463966 changes. I added NO_BITMAPS to OPTIONS_DEFAULT as this PR proposed, but I don't know about whether this option should be enabled by default or not. Previously, = it was as fontconfig's developers configured by default. - Bump PORTREVISION - Add NO_BITMAPS option - Add OPTIONS_SUB=3Dyes and adapt pkg-plist - Convert files/patch-conf.d_Makefile.in to sed patch