From owner-freebsd-ports Thu Sep 5 6:10: 8 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B4A837B400 for ; Thu, 5 Sep 2002 06:10:03 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5673243E42 for ; Thu, 5 Sep 2002 06:10:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g85DA3JU017231 for ; Thu, 5 Sep 2002 06:10:03 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g85DA3dO017230; Thu, 5 Sep 2002 06:10:03 -0700 (PDT) Date: Thu, 5 Sep 2002 06:10:03 -0700 (PDT) Message-Id: <200209051310.g85DA3dO017230@freefall.freebsd.org> To: freebsd-ports@FreeBSD.org Cc: From: Tim Vanderhoek Subject: Re: ports/42300: [PATCH] Allow building when the -f makefile option is specified Reply-To: Tim Vanderhoek Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR ports/42300; it has been noted by GNATS. From: Tim Vanderhoek To: Dan Langille Cc: FreeBSD-gnats-submit@FreeBSD.org, wvengen@stack.nl Subject: Re: ports/42300: [PATCH] Allow building when the -f makefile option is specified Date: Thu, 5 Sep 2002 09:02:29 -0400 [Various bits of silent eliding below...] On Thu, Sep 05, 2002 at 08:55:29AM -0400, Dan Langille wrote: > > > MAINDIR= ${.CURDIR}/../sword > > > +MKFILE!= /usr/bin/basename ${MAKEFILE} > > > > Since ${MAINDIR} always refers to another port directory, I > > think that it is better in this case to simply do: > > > > -PORTVERSION= ${MAKE} -V PORTVERSION -f ${MAINDIR}/${MAKEFILE} > > +PORTVERSION= ${MAKE} -V PORTVERSION -f ${MAINDIR}/Makefile > > I thought further about this. What if ${MAKEFILE} != Makefile? I would suggest that if /usr/ports/games/sword/Makefile is called something other than "Makefile", then sword is broken. -- If I could think of a two-line witty aphorism for you to remember me by, this would definitely be it. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message