From owner-svn-src-head@FreeBSD.ORG Sat Jul 6 00:10:53 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0FC83763; Sat, 6 Jul 2013 00:10:53 +0000 (UTC) (envelope-from jamie@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 01E7C1C0B; Sat, 6 Jul 2013 00:10:53 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r660AqQV036924; Sat, 6 Jul 2013 00:10:52 GMT (envelope-from jamie@svn.freebsd.org) Received: (from jamie@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r660Aqsp036921; Sat, 6 Jul 2013 00:10:52 GMT (envelope-from jamie@svn.freebsd.org) Message-Id: <201307060010.r660Aqsp036921@svn.freebsd.org> From: Jamie Gritton Date: Sat, 6 Jul 2013 00:10:52 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r252855 - in head/sys: kern sys X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jul 2013 00:10:53 -0000 Author: jamie Date: Sat Jul 6 00:10:52 2013 New Revision: 252855 URL: http://svnweb.freebsd.org/changeset/base/252855 Log: Make the comments a little more clear about PRIV_KMEM_*, explicitly referring to /dev/[k]mem and noting it's about opening the files rather than actually reading and writing. Reviewed by: jmallett Modified: head/sys/kern/kern_priv.c head/sys/sys/priv.h Modified: head/sys/kern/kern_priv.c ============================================================================== --- head/sys/kern/kern_priv.c Fri Jul 5 23:40:08 2013 (r252854) +++ head/sys/kern/kern_priv.c Sat Jul 6 00:10:52 2013 (r252855) @@ -142,8 +142,9 @@ priv_check_cred(struct ucred *cred, int } /* - * Writes to kernel memory are a typical root-only operation, - * but non-root users are expected to be able to read it. + * Writes to kernel/physical memory are a typical root-only operation, + * but non-root users are expected to be able to read it (provided they + * have permission to access /dev/[k]mem). */ if (priv == PRIV_KMEM_READ) { error = 0; Modified: head/sys/sys/priv.h ============================================================================== --- head/sys/sys/priv.h Fri Jul 5 23:40:08 2013 (r252854) +++ head/sys/sys/priv.h Sat Jul 6 00:10:52 2013 (r252855) @@ -494,10 +494,10 @@ #define PRIV_RCTL_REMOVE_RULE 674 /* - * Kernel memory privileges. + * mem(4) privileges. */ -#define PRIV_KMEM_READ 680 /* Read from kernel memory. */ -#define PRIV_KMEM_WRITE 681 /* Write to kernel memory. */ +#define PRIV_KMEM_READ 680 /* Open mem/kmem for reading. */ +#define PRIV_KMEM_WRITE 681 /* Open mem/kmem for writing. */ /* * Track end of privilege list.