From owner-svn-ports-head@FreeBSD.ORG Thu Dec 26 10:28:51 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9AB4356C; Thu, 26 Dec 2013 10:28:51 +0000 (UTC) Received: from mail-ee0-x231.google.com (mail-ee0-x231.google.com [IPv6:2a00:1450:4013:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B5A2013A2; Thu, 26 Dec 2013 10:28:50 +0000 (UTC) Received: by mail-ee0-f49.google.com with SMTP id c41so3619015eek.36 for ; Thu, 26 Dec 2013 02:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=pw2cV+E2hiDYnUSf4Dj8NVpZaMgIcKae7cB5CTS+AiI=; b=NZfxnbMtd6Q4jD5n3Erzrkt6gNh3tUhuImNQ178DPJlbcbcAA3O82zc79PUp7grXKI HYmXS4paeJieQSVQvicPXJ3MAooAGww+Wuh9P5Stir7anEaRBwjQDMvjyeoop6r98ADb ATpHWZmvaHV0HpkNztoDmsDWLpRNH6TBpVjdoMz3AWLAbj35Oi9M1A78txpcnCZQRkny zzjgc1XkxmzCCgEEb7xKlYnfg8j8zg88I8/9qeX3H/aLkVb0WGv8pv9nRQokMW6eCU2U y0tjpJ5sf308FjU8M0M9zH5jkAJy39BSSe23gW7grdNPD5gKhVvGPzyQyCP3s4AXAPuN +c4w== X-Received: by 10.15.63.134 with SMTP id m6mr6934752eex.74.1388053729154; Thu, 26 Dec 2013 02:28:49 -0800 (PST) Received: from localhost ([176.109.164.5]) by mx.google.com with ESMTPSA id o1sm71589597eea.10.2013.12.26.02.28.47 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Thu, 26 Dec 2013 02:28:48 -0800 (PST) Sender: =?UTF-8?B?UGF3ZcWCIFDEmWthbGE=?= Date: Thu, 26 Dec 2013 11:28:28 +0100 From: Pawel Pekala To: Alexey Dokuchaev Subject: Re: svn commit: r337439 - head/www/cntlm Message-ID: <20131226112828.4487544a@FreeBSD.org> In-Reply-To: <20131226051343.GA69157@FreeBSD.org> References: <201312251916.rBPJGnSw066524@svn.freebsd.org> <20131226051343.GA69157@FreeBSD.org> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Dec 2013 10:28:51 -0000 Hi Alexey, On 2013-12-26 05:13 +0000, Alexey Dokuchaev wrote: >On Wed, Dec 25, 2013 at 07:16:49PM +0000, Pawel Pekala wrote: >> New Revision: 337439 >> URL: http://svnweb.freebsd.org/changeset/ports/337439 >>=20 >> Log: >> Fix build on -current >> =20 >> [...] >> do-install: >> - ${INSTALL_PROGRAM} ${WRKSRC}/cntlm ${STAGEDIR}${PREFIX}/bin/ >> - ${INSTALL_DATA} ${WRKSRC}/doc/cntlm.conf >> ${STAGEDIR}${PREFIX}/etc/cntlm.conf.sample >> - ${INSTALL_MAN} ${WRKSRC}/doc/cntlm.1 >> ${STAGEDIR}${MAN1PREFIX}/man/man1 >> + (cd ${WRKSRC} && ${INSTALL_PROGRAM} cntlm \ >> + ${STAGEDIR}${PREFIX}/bin) >> + (cd ${WRKSRC}/doc && ${INSTALL_DATA} cntlm.conf.sample \ >> + ${STAGEDIR}${PREFIX}/etc) >> + (cd ${WRKSRC}/doc && ${INSTALL_MAN} cntlm.1 \ >> + ${STAGEDIR}${MANPREFIX}/man/man1) > >Pawel, > >The last hunk has nothing to do with "fixing the build on current", it >makes the code harder to read (6 lines instead of three, line >wrapping), and is a gratuitous (and plain bad) change. > >I appreciate Katobot's build fixing PR's and patches, but let's not >take them as perfect and use it in their entirety, esp. when they >contradict our normal practices and style. Firstly I find it disrespectful to call someone a 'bot', please don't go there. I treat every PR the same - fix small stuff by myself, communicate about larger issues and wait for improved version. Kato's PRs are not exception from this, I fix trivial things mostly and many commits are not verbatim copy from PR. Thanks for pointing out this issue to me, I will more careful about these in the future. --=20 pozdrawiam / with regards Pawe=B3 P=EAkala