From owner-freebsd-wireless@freebsd.org Mon May 21 20:39:38 2018 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA538EFDCA7 for ; Mon, 21 May 2018 20:39:37 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wr0-x232.google.com (mail-wr0-x232.google.com [IPv6:2a00:1450:400c:c0c::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 546FC6F5BA for ; Mon, 21 May 2018 20:39:37 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wr0-x232.google.com with SMTP id j1-v6so6299748wrm.1 for ; Mon, 21 May 2018 13:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HGYArW7Li6A3ZEDCqusp+EGxqQ2k0GzCqZG8/WmUfZE=; b=cf5IQSRLL/rbgh43Dzs04UVlYFajesSBEWN5S4lqDRKctoIGLXGPifXyXl0TWU4zp3 I5HCuwsUgv07IXD+9BKv3L+x9QB2al+aefv7Lsu6xwXRtQ1+UCRT+zokMRtEyo0flEVr XbadQ6FFxDy+K6ShBM2S4Fe20PRjhoVezdbxqM5mUwrVsCk/ZR6/FMRYrU45iz7SzqK9 Rv5aLtB9bHG7dL4cv1D+1Q7AYLg9F685YlA+7QiGDw9LRq+8xFRbAGx+SZN9hHPuf4Ns 25y6Znb7lv28RWWpYBlAvloXIaq3K5ZVtGrXNlGS0Y8QHiV+lNb0xU+y2vS+7OHpban2 SNjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HGYArW7Li6A3ZEDCqusp+EGxqQ2k0GzCqZG8/WmUfZE=; b=AFcatUvKOkDIC4dtJ9NEAaUUCi+rExwVJlZW8/jD9PdxS5zqkehld0dfr+bYo4fABP 3tJ29O6x0yb70/s+PFX2G8Vo8hCCF4E9jdhkHh/NcszEQszkxf7N7Pe11rYm5k9HaLCn zuAtXgEICsQ4HWcatr9kOpxP3iXBzSw9FNqlw65BGPLWu/pZ7CFRFp0kh9LpNUZ2zl13 TYXBm4CFljFbdYo0/NOvgf67LLCmDE2tItalAs+C/7BQMR3FIWhxngr2M+5HhwvqMFH5 /LLxphBG3Kls+t7CSr/9ilDuvHvHLErrMVonTS9P79rXLP+3PZxfPs6vV2Tp0o0RNAsY Oeuw== X-Gm-Message-State: ALKqPwdkB8WNSUxIe/xqYV6tf3VpAnyvbw6doMlJUdokX6I8HIaKucah oUDKYuXBYZPVu+cmYxwKt446pqkPYmlf7zFzstc= X-Google-Smtp-Source: AB8JxZq3sslmqKtgFBRTXlRwp8VI/fZYJmYNyB/caDccrbHIvk+h5TsZhx2n/uHZQfuP24rJ4ELi6eW6xULQJx/lqdc= X-Received: by 2002:adf:ac4f:: with SMTP id v73-v6mr15790476wrc.5.1526935176279; Mon, 21 May 2018 13:39:36 -0700 (PDT) MIME-Version: 1.0 References: <20180502165745.59a5bfc4@bigbox.christie.dr> <20180502211001.550d290c@bigbox.christie.dr> <20180503192743.639240d0@bigbox.christie.dr> <20180504005448.GA89012@bluezbox.com> <20180506201659.0a831f5f@bigbox.christie.dr> <20180521140745.65243721@bigbox.christie.dr> In-Reply-To: From: Adrian Chadd Date: Mon, 21 May 2018 13:39:22 -0700 Message-ID: Subject: Re: ath0: could not map interrupt (again?) To: freebsd@tim.thechases.com Cc: Oleksandr Tymoshenko , "freebsd-wireless@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 20:39:38 -0000 And Tim - is this really mini-pci? or is it mini-pcie? (can you take a photo? :-) -a On Mon, 21 May 2018 at 13:34, Adrian Chadd wrote: > hi, > warner says "pcie interrupts aren't shared." :-) > So why is this working? You're saying this is a mini-pci slot? > Would you please file a PR so we can get some more eyeballs on this? thanks! > -adrian > On Mon, 21 May 2018 at 12:55, Tim Chase wrote: > > I've been using this for a couple weeks now with no issues, for what > > little value my OK is, your patch seems to be ready to roll. > > -tim > > On 2018-05-06 20:16, Tim Chase wrote: > > > On 2018-05-03 17:54, Oleksandr Tymoshenko wrote: > > > > Tim Chase (freebsd@tim.thechases.com) wrote: > > > > > ppb0 at pci0 dev 28 function 0 "Intel SCH PCIE" rev 0x07: apic 2 > > > > > int 17 ... > > > > > athn0 at pci2 dev 0 function 0 "Atheros AR9281" rev 0x01: apic 2 > > > > > int 17 athn0: AR9280 rev 2 (2T2R), ROM rev 22, address > > > > > 00:24:d2:b3:8c:b4 > > > > > > > > > > so it looks like the interrupt *can* be shared, it just appears > > > > > that FreeBSD is doing something peculiar with it. > > > > > > > > It looks like PCI bridge allocates interupt without RF_SHAREABLE > > > > (see dev/pci/pci_pci.c, pcib_alloc_pcie_irq). Could you test > > > > this patch [1]? I am not sure if non-shareable IRQs for PCI/PCI > > > > bridge is a design decision or it's just that nobody has hit this > > > > problem before. > > > > > > > > [1] > > > > https://people.freebsd.org/~gonzo/patches/pci_pci-shareable-irq.diff > > > > > > Applying your one-line patch adding RF_SHAREABLE (sorry for the > > > delay as buildworld took ~2.5 days and buildkernel took about half > > > a day on this machine) does seem to have at least gotten past the > > > initial issue. The pcib1 now looks like it's properly sharing the > > > interrupt and ath0 at least identifies. Relevant excerpts from > > > dmesg: > > > > > > # dmesg | grep -e ath0 -e pcib1 > > > pcib1: irq 17 at device 28.0 on pci0 > > > pcib1: [GIANT-LOCKED] > > > pci1: on pcib1 > > > ath0: mem 0xd8000000-0xd800ffff irq 17 at device 0.0 > > > on pci2 ath0: [HT] enabling HT modes > > > ath0: [HT] 1 stream STBC receive enabled > > > ath0: [HT] 1 stream STBC transmit enabled > > > ath0: [HT] 2 RX streams; 2 TX streams > > > ath0: AR9280 mac 128.2 RF5133 phy 13.0 > > > ath0: 2GHz radio: 0x0000; 5GHz radio: 0x00c0 > > > > > > This was performed against HEAD which, at the time, was r333254. > > > > > > I'll poke at it more thoroughly in the morning, but I wanted to let > > > you know that it seems to be working thus far. > > > > > > If you know of any particular ways in which I should stress it (to > > > see if IRQ 17 on pcib1 really *wasn't* supposed to be sharable), I'd > > > be glad to abuse it a bit. > > > > > > Many thanks! > > > > > > -tim > > > > > > > > > > > > > > _______________________________________________ > > freebsd-wireless@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-wireless > > To unsubscribe, send any mail to " freebsd-wireless-unsubscribe@freebsd.org > "