From owner-freebsd-java@FreeBSD.ORG Thu Oct 30 15:03:27 2003 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7EDD16A564 for ; Thu, 30 Oct 2003 15:03:27 -0800 (PST) Received: from mgr3.xmission.com (mgr3.xmission.com [198.60.22.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C82243F75 for ; Thu, 30 Oct 2003 15:03:26 -0800 (PST) (envelope-from glewis@eyesbeyond.com) Received: from mail by mgr3.xmission.com with spam-scanned (Exim 3.35 #1) id 1AFLp7-0005lS-03 for freebsd-java@freebsd.org; Thu, 30 Oct 2003 16:03:25 -0700 Received: from [207.135.128.145] (helo=misty.eyesbeyond.com) by mgr3.xmission.com with esmtp (Exim 3.35 #1) id 1AFLp2-0005i8-03; Thu, 30 Oct 2003 16:03:20 -0700 Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) h9UN5NjG042654; Thu, 30 Oct 2003 16:05:24 -0700 (MST) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.12.9p1/8.12.9/Submit) id h9UN5Fe4042644; Thu, 30 Oct 2003 16:05:15 -0700 (MST) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Thu, 30 Oct 2003 16:05:14 -0700 From: Greg Lewis To: Christopher Rued Message-ID: <20031030230514.GA42573@misty.eyesbeyond.com> References: <3FA13C93.8010105@xsb.com> <1067532264.27956.27.camel@dyn231.iacc-tm4.ndsu.nodak.edu> <3FA1456B.8080404@xsb.com> <20031030172034.GB40447@misty.eyesbeyond.com> <3FA14A17.3000908@xsb.com> <3FA14F85.8060205@xsb.com> <20031030203556.GA41868@misty.eyesbeyond.com> <3FA19100.2080001@xsb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FA19100.2080001@xsb.com> User-Agent: Mutt/1.4.1i X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on mgr3.xmission.com X-Spam-Status: No, hits=-0.9 required=8.0 tests=BAYES_30 autolearn=no version=2.60 X-Spam-Level: cc: freebsd-java@freebsd.org Subject: Re: Assertion failure while compiling jdk14 X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Oct 2003 23:03:27 -0000 On Thu, Oct 30, 2003 at 05:30:24PM -0500, Christopher Rued wrote: > Greg Lewis wrote: > > >Look at j2se/make/common/Defs.gmk. It currently contains the patch to > >set javah_g to javah on BSD. Try adding a similar thing for the JAVAC > >variable. > > > I did what you said (here's a patch showing what I changed): > > --- j2se/make/common/Defs.gmk~ Wed Oct 29 16:42:00 2003 > +++ j2se/make/common/Defs.gmk Thu Oct 30 16:41:03 2003 > @@ -464,6 +464,7 @@ > # --phantom > ifeq ($(PLATFORM), bsd) > JAVAH_CMD = $(BINDIR)/javah > + JAVAC_CMD = $(BINDIR)/javac > endif > RMIC = $(BINDIR)/rmic$(SUFFIX) > endif Thats not quite right. You need to redefine JAVAC, not JAVAC_CMD. > And then I ran `make install` from /usr/ports/java/jdk14. It still > tries to use javac_g, and it still fails in exactly the same way :-(. > I didn't run make clean first, but as far as I can tell, that shouldn't > make a difference. I'm browing Makefiles and .gmk files right now > trying to figure out why this change didn't seem to take hold. > > Does the patch look right to you? > Do I need to do a `make clean`, `make patch`, apply my patch, and *then* > `make install`? Depends how you are doing the patch. It sounds like you're just editing the file, so you probably don't need a make clean. If you were sticking the patch into the files directory then you would need to. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org