From nobody Thu Apr 16 06:06:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fx6wD6hwWz6Z0ZH for ; Thu, 16 Apr 2026 06:06:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fx6wD3wtPz3hxB for ; Thu, 16 Apr 2026 06:06:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776319596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ezDz5NlZKfSN2gJiZVWZS6phOcVss9Wffy3Zv0alfVk=; b=P9QLwCEybGC7JCzwSk20GcoVkvo9+K0GLDqOFA8aDVROwmfN9o3wdaMD4KT4MtcH8oj/L+ eXlurrZ/hnP94uNe5oZCx+EgRF5fUz4Gt5Ri2zLaKrlM+Mv5xJ30lqiTu+Jhv77At9vPXV oUk3B9FlVkwJkukiU74gwaiLOLerNT7zYS6d0XwXWClMw4VK7gqY6M2KvCLDjemxcPkp90 V/WLHsN6KV7J3jyoeTCRvWooQdk7kxqKwcN4JJJkamRBI1qSr0o6YtB5aBXs1XSEl/diYT PnK8m3QcaSD+qMvg05BJ+ATQs7feLMvepVF+JPFQr+WzgY3MZndrJc9WHsFWKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776319596; a=rsa-sha256; cv=none; b=EMj9Z8HPx/slkDDXePtAfK9vSQwmBFexjF6s9nDqHqQQh4WN6u1R74vEaPRBKn3YC0OHhr x1AxWHeTALsBeHxHP9OCTsrvnO95C7hScGmrTurM9XqytxrfEPBWkPd/il7EuedXXatGWW 3w0NiZQXVwCxwK1LZGwgzBvl4PDG9jEMZgTC6toI7zUpweTfe0rWyB0tjf6LlMKUDhIKCe lDbF4aYrsGP9+KuuXrVRcWX8A0eqbg8kSQoEtdlEv8cf85wuJyZobpZuGGF8i5eVdY9Pdb e761EQ2GO1xIZ6jalxnzsuqR4TejRIrxf2fFYlKk5RehNMAYu98F8KUuS0/cOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776319596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ezDz5NlZKfSN2gJiZVWZS6phOcVss9Wffy3Zv0alfVk=; b=gLADv9FoNGTb5OewfCqR+LxP/4YmKRnnYu/fmctl5tOLDuGF0tlNvqCQyFGd3A6aQy9UqN Hpn7PqQW40lYPjV0Ibgm4eka+RKmhXWVbeT34Cz9JmXx6ATc1kyCsFMBWyQ3BENbRB138l gTi9uDs8uMZuIPB9m6Juad3CWcDkaVmxMiS9XCWye55lS3nxRzJTZkWaIXff9OSxJMnLlR K/Cnt/hThHBYjVjI9K5Wz4O461DPnr1eb35nerrHvWQiMO3K5wYusUTtzjBA/ENNE4zRLP TfTTH4+RVYcW07+l5TFNMQ3UZK/3i0W/0/HiIKb3d/ecdvBJHaaQEd9zwdKiww== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fx6wD2YhwzvyT for ; Thu, 16 Apr 2026 06:06:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cb59 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 16 Apr 2026 06:06:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ryan Moeller From: Warner Losh Subject: git: 20cd1b475a1e - main - lib/libifconfig: Fix pointer-sign warnings List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 20cd1b475a1ef9dfca30726999aa1b9a02d5bc39 Auto-Submitted: auto-generated Date: Thu, 16 Apr 2026 06:06:36 +0000 Message-Id: <69e07c6c.3cb59.126f7498@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=20cd1b475a1ef9dfca30726999aa1b9a02d5bc39 commit 20cd1b475a1ef9dfca30726999aa1b9a02d5bc39 Author: Ryan Moeller AuthorDate: 2025-09-18 15:04:35 +0000 Commit: Warner Losh CommitDate: 2026-04-16 06:05:22 +0000 lib/libifconfig: Fix pointer-sign warnings Fix all pointer-sign warnings generated when compiling libifconfig. One of these warnings comes from the misuse of snl_add_msg_attr_string for a byte array. Though userland treats carpr_key as a string, it is actually an array of bytes. Handle it as such in libifconfig. While here, fix a small consistency nit in ifconfig_sfp_get_sfp_dump. Signed-off-by: Ryan Moeller Reviewed by: imp, zlei Pull Request: https://github.com/freebsd/freebsd-src/pull/1850 --- lib/libifconfig/libifconfig_carp.c | 5 +++-- lib/libifconfig/libifconfig_sfp.c | 10 +++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/libifconfig/libifconfig_carp.c b/lib/libifconfig/libifconfig_carp.c index 59faa8def496..8599470cd3f9 100644 --- a/lib/libifconfig/libifconfig_carp.c +++ b/lib/libifconfig/libifconfig_carp.c @@ -53,7 +53,7 @@ static struct snl_attr_parser ap_carp_get[] = { { .type = CARP_NL_STATE, .off = _OUT(carpr_state), .cb = snl_attr_get_uint32 }, { .type = CARP_NL_ADVBASE, .off = _OUT(carpr_advbase), .cb = snl_attr_get_int32 }, { .type = CARP_NL_ADVSKEW, .off = _OUT(carpr_advskew), .cb = snl_attr_get_int32 }, - { .type = CARP_NL_KEY, .off = _OUT(carpr_key), .cb = snl_attr_copy_string, .arg_u32 = CARP_KEY_LEN }, + { .type = CARP_NL_KEY, .off = _OUT(carpr_key), .cb = snl_attr_get_bytes, .arg_u32 = CARP_KEY_LEN }, { .type = CARP_NL_ADDR, .off = _OUT(carpr_addr), .cb = snl_attr_get_in_addr }, { .type = CARP_NL_ADDR6, .off = _OUT(carpr_addr6), .cb = snl_attr_get_in6_addr }, { .type = CARP_NL_VERSION, .off = _OUT(carpr_version), .cb = snl_attr_get_uint8 }, @@ -177,7 +177,8 @@ ifconfig_carp_set_info(ifconfig_handle_t *h, const char *name, &carpr->carpr_addr); snl_add_msg_attr(&nw, CARP_NL_ADDR6, sizeof(carpr->carpr_addr6), &carpr->carpr_addr6); - snl_add_msg_attr_string(&nw, CARP_NL_KEY, carpr->carpr_key); + snl_add_msg_attr(&nw, CARP_NL_KEY, sizeof(carpr->carpr_key), + carpr->carpr_key); snl_add_msg_attr_u8(&nw, CARP_NL_VERSION, carpr->carpr_version); snl_add_msg_attr_u8(&nw, CARP_NL_VRRP_PRIORITY, carpr->carpr_vrrp_prio); snl_add_msg_attr_u16(&nw, CARP_NL_VRRP_ADV_INTER, carpr->carpr_vrrp_adv_inter); diff --git a/lib/libifconfig/libifconfig_sfp.c b/lib/libifconfig/libifconfig_sfp.c index 8deccda5ff76..a2cddf89a13a 100644 --- a/lib/libifconfig/libifconfig_sfp.c +++ b/lib/libifconfig/libifconfig_sfp.c @@ -298,7 +298,7 @@ ifconfig_sfp_get_sfp_info(ifconfig_handle_t *h, const char *name, struct ifconfig_sfp_info *sfp) { struct i2c_info ii; - char buf[8]; + uint8_t buf[8]; memset(sfp, 0, sizeof(*sfp)); @@ -365,7 +365,7 @@ ifconfig_sfp_channel_count(const struct ifconfig_sfp_info *sfp) static void get_sff_string(struct i2c_info *ii, uint8_t addr, uint8_t off, char *dst) { - read_i2c(ii, addr, off, SFF_VENDOR_STRING_SIZE, dst); + read_i2c(ii, addr, off, SFF_VENDOR_STRING_SIZE, (uint8_t *)dst); dst += SFF_VENDOR_STRING_SIZE; do { *dst-- = '\0'; } while (*dst == 0x20); } @@ -373,7 +373,7 @@ get_sff_string(struct i2c_info *ii, uint8_t addr, uint8_t off, char *dst) static void get_sff_date(struct i2c_info *ii, uint8_t addr, uint8_t off, char *dst) { - char buf[SFF_VENDOR_DATE_SIZE]; + uint8_t buf[SFF_VENDOR_DATE_SIZE]; read_i2c(ii, addr, off, SFF_VENDOR_DATE_SIZE, buf); sprintf(dst, "20%c%c-%c%c-%c%c", buf[0], buf[1], buf[2], buf[3], @@ -532,7 +532,7 @@ get_sfp_status(struct i2c_info *ii, struct ifconfig_sfp_status *ss) uint8_t diag_type, flags; /* Read diagnostic monitoring type */ - read_i2c(ii, SFF_8472_BASE, SFF_8472_DIAG_TYPE, 1, (caddr_t)&diag_type); + read_i2c(ii, SFF_8472_BASE, SFF_8472_DIAG_TYPE, 1, &diag_type); if (ii->error != 0) return (-1); @@ -773,7 +773,7 @@ ifconfig_sfp_get_sfp_dump(ifconfig_handle_t *h, const char *name, struct i2c_info ii; uint8_t *buf = dump->data; - memset(dump->data, 0, sizeof(dump->data)); + memset(buf, 0, sizeof(dump->data)); if (i2c_info_init(&ii, h, name) != 0) return (-1);