Date: Tue, 19 Mar 2002 11:46:00 -0800 From: Peter Wemm <peter@wemm.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 7933 for review Message-ID: <20020319194600.B2BB33810@overcee.wemm.org> In-Reply-To: <XFMail.20020319131141.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > > On 19-Mar-2002 Peter Wemm wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7933 > > > > Change 7933 by peter@peter_overcee on 2002/03/19 01:29:12 > > > > add the ia64 IO tag, and add a #error to catch this in future. > > > > Affected files ... > > > > ... //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 edit > > > > Differences ... > > > > ==== //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 (text+ko) ==== > > > > @@ -159,6 +159,10 @@ > > tag = I386_BUS_SPACE_IO; > > #elif defined(__alpha__) > > tag = busspace_isa_io; > > +#elif defined(__ia64__) > > + tag = IA64_BUS_SPACE_IO; > > +#else > > +#error "define tag!" > > #endif > > > > #if notyet > > Maybe there should be a MD macro to define what the appropriate bus tag is? Actually, this should use the proper API's instead of hacking around like this. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020319194600.B2BB33810>