Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Apr 2019 17:11:50 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r346157 - head/sys/fs/tmpfs
Message-ID:  <201904121711.x3CHBoeu075068@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Fri Apr 12 17:11:50 2019
New Revision: 346157
URL: https://svnweb.freebsd.org/changeset/base/346157

Log:
  Ignore doomed vnodes in tmpfs_update_mtime().
  
  Otherwise we might dereference NULL vp->v_data after
  VP_TO_TMPFS_NODE().
  
  Reported and tested by:	pho
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/fs/tmpfs/tmpfs_vfsops.c

Modified: head/sys/fs/tmpfs/tmpfs_vfsops.c
==============================================================================
--- head/sys/fs/tmpfs/tmpfs_vfsops.c	Fri Apr 12 15:15:27 2019	(r346156)
+++ head/sys/fs/tmpfs/tmpfs_vfsops.c	Fri Apr 12 17:11:50 2019	(r346157)
@@ -173,7 +173,7 @@ tmpfs_update_mtime(struct mount *mp, bool lazy)
 		 * metadata changes now.
 		 */
 		if (!lazy || (obj->flags & OBJ_TMPFS_DIRTY) != 0) {
-			if (vget(vp, LK_EXCLUSIVE | LK_RETRY | LK_INTERLOCK,
+			if (vget(vp, LK_EXCLUSIVE | LK_INTERLOCK,
 			    curthread) != 0)
 				continue;
 			tmpfs_check_mtime(vp);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904121711.x3CHBoeu075068>