From owner-cvs-all@FreeBSD.ORG  Thu Jan 19 19:25:56 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 157BE16A41F;
	Thu, 19 Jan 2006 19:25:56 +0000 (GMT)
	(envelope-from jasone@canonware.com)
Received: from lh.synack.net (lh.synack.net [204.152.188.37])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B67C443D45;
	Thu, 19 Jan 2006 19:25:55 +0000 (GMT)
	(envelope-from jasone@canonware.com)
Received: by lh.synack.net (Postfix, from userid 100)
	id 8400D5E48EE; Thu, 19 Jan 2006 11:25:55 -0800 (PST)
Received: from [192.168.168.203]
	(moscow-cuda-gen2-68-64-60-20.losaca.adelphia.net [68.64.60.20])
	(using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by lh.synack.net (Postfix) with ESMTP id B2D785E48D5;
	Thu, 19 Jan 2006 11:25:53 -0800 (PST)
In-Reply-To: <200601191920.k0JJKhLr086529@repoman.freebsd.org>
References: <200601191920.k0JJKhLr086529@repoman.freebsd.org>
Mime-Version: 1.0 (Apple Message framework v746.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <32B9C327-E083-428E-B91E-849DF7CB12F2@canonware.com>
Content-Transfer-Encoding: 7bit
From: Jason Evans <jasone@canonware.com>
Date: Thu, 19 Jan 2006 11:25:50 -0800
To: Jason Evans <jasone@FreeBSD.org>
X-Mailer: Apple Mail (2.746.2)
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on lh.synack.net
X-Spam-Level: *
X-Spam-Status: No, score=1.8 required=5.0 tests=RCVD_IN_NJABL_DUL,
	RCVD_IN_SORBS_DUL autolearn=no version=3.0.4
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jan 2006 19:25:56 -0000

On Jan 19, 2006, at 11:20 AM, Jason Evans wrote:
> jasone      2006-01-19 19:20:43 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     lib/libc/stdlib      malloc.c
>   Log:
>   Revert addtion of assertions in revision 1.99.  These assertions  
> cause
>   problems in cases where regions are faked up for the purposes of  
> red-black
>   tree searches, since those faked region headers reside on the  
> stack, rather
>   than in a malloc chunk.

Sorry about this, folks.  I thought that I had tested this well  
before committing it, but it turns out I forgot to actually use the  
modified libc during testing.

There's a 12 minute window during which malloc was broken in the  
tree.  You really don't want revision 1.99 of malloc.c, so make sure  
to avoid it.

Jason