From owner-cvs-all@FreeBSD.ORG  Wed Dec  6 23:25:18 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1E1CA16A40F
	for <cvs-all@FreeBSD.org>; Wed,  6 Dec 2006 23:25:18 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5])
	by mx1.FreeBSD.org (Postfix) with SMTP id ED99343CB7
	for <cvs-all@FreeBSD.org>; Wed,  6 Dec 2006 23:24:27 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 17881 invoked by uid 399); 6 Dec 2006 23:25:14 -0000
Received: from localhost (HELO ?192.168.0.7?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with SMTP; 6 Dec 2006 23:25:14 -0000
X-Originating-IP: 127.0.0.1
Message-ID: <45775157.4030900@FreeBSD.org>
Date: Wed, 06 Dec 2006 15:25:11 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.freebsd.org/
User-Agent: Thunderbird 1.5.0.8 (X11/20061125)
MIME-Version: 1.0
To: Robert Watson <rwatson@FreeBSD.org>
References: <200609241731.k8OHV5mZ053132@repoman.freebsd.org>
In-Reply-To: <200609241731.k8OHV5mZ053132@repoman.freebsd.org>
X-Enigmail-Version: 0.94.1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/rc.d auditd
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2006 23:25:18 -0000

Catching up on some old mail ...

Robert Watson wrote:
> rwatson     2006-09-24 17:31:04 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/rc.d             auditd 
>   Log:
>   Sleep for one second after calling audit -t to give the audit daemon a
>   chance to actually terminate the audit service and exit.  Otherwise, on
>   an rc.d/auditd restart, the new audit daemon instance may try to start
>   auditing while the previous session is still running.  Likewise, this
>   ensures a chance for auditd to terminate the audit trail at system
>   shutdown.
>   
>   Perhaps more ideally, the script would wait synchronously for auditd to
>   exit rather than for an arbitrary but short period of time.
>   
>   MFC after:      3 days
>   Obtained from:  TrustedBSD Project
>   
>   Revision  Changes    Path
>   1.3       +1 -0      src/etc/rc.d/auditd
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/auditd.diff?&r1=1.2&r2=1.3&f=h

Perhaps a better change would be:

/usr/sbin/audit -t
while : ; do
	if <something that indicates audit is not dead yet>; then
		echo 'Waiting for the audit system to terminate'
		sleep 1
	else
		break
	fi
done

hth,

Doug

-- 

    This .signature sanitized for your protection