From owner-svn-ports-head@freebsd.org  Thu Dec  7 07:49:18 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97698EA0211;
 Thu,  7 Dec 2017 07:49:18 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 785417AA7C;
 Thu,  7 Dec 2017 07:49:18 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id AA3F71CE16; Thu,  7 Dec 2017 07:49:17 +0000 (UTC)
Date: Thu, 7 Dec 2017 07:49:17 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org, hselasky@FreeBSD.org
Subject: Re: svn commit: r455665 - head/audio/zynaddsubfx
Message-ID: <20171207074917.GA7726@FreeBSD.org>
References: <201712061730.vB6HU6hn021797@repo.freebsd.org>
 <20171206174407.GA82869@FreeBSD.org>
 <20171206175217.GV68137@fc.opsec.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171206175217.GV68137@fc.opsec.eu>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Dec 2017 07:49:18 -0000

On Wed, Dec 06, 2017 at 06:52:17PM +0100, Kurt Jaeger wrote:
> > > Log:
> > >   audio/zynaddsubfx: fix build on cur, 10.x by force llvm40
> > 
> > Commit message does not explain what was the original problem, so it's
> > hard to judge whether attempted solution is correct or not.
> 
> Yes, as usual the saying goes: look at the PR, and you'll find the
> links to the build logs that failed. hps will probably dig into it
> if he finds time.

Kurt,

Sorry, but this does not work this way.  Commit logs should be self-
sufficient, elaborate, and completely describing original problem,
analysis of it, and rationale for attempted solution.  Bugzilla can
go offline, links to the builds logs become stale and 404.

> Would we add it if it would not be missing?

Well I don't know, because it was not mentioned in the commit log. :-)
People often commit unintended changes.  That's why it is important to
provide elaborate commit message which explains everything that went to
the commit batch.  Not just it would be helpful to future readers, it
would also be helpful to the committer (like catching unrelated and/or
bogus changes that somehow sneaked in).

> > > +.include <bsd.port.options.mk>
> > 
> > What is this .include <bsd.port.options.mk> needed for?
> 
> hps added it, and so it went in. I doubt it's necessary, so hps
> can remove it when he updates the port the next time.

hps@ is not a ports committer; it is your responsibility to thoroughly
review proposed changes and clarify any "doubts".  It's also OK, and
actually encouraged, to ask for a third pair of eyes.

./danfe