From owner-svn-src-all@FreeBSD.ORG Sun Sep 22 22:05:27 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id AA9FCAD5; Sun, 22 Sep 2013 22:05:27 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 679E129B6; Sun, 22 Sep 2013 22:05:27 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::fc32:4a94:3a4c:ac46] (unknown [IPv6:2001:7b8:3a7:0:fc32:4a94:3a4c:ac46]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 02DE85C44; Mon, 23 Sep 2013 00:05:25 +0200 (CEST) From: Dimitry Andric Content-Type: multipart/signed; boundary="Apple-Mail=_3A138EFF-51E4-4225-AC3A-C67DB491AEB7"; protocol="application/pgp-signature"; micalg=pgp-sha1 Message-Id: <427467AD-F9D7-47AF-A271-DEB719985F18@FreeBSD.org> Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: svn commit: r255804 - in head/contrib/llvm/lib: CodeGen/SelectionDAG Target/AArch64 Target/ARM Target/Hexagon Target/MSP430 Target/Mips Target/NVPTX Target/PowerPC Target/R600 Target/Sparc Target/S... Date: Mon, 23 Sep 2013 00:05:23 +0200 References: <201309222203.r8MM3UjJ006580@svn.freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <201309222203.r8MM3UjJ006580@svn.freebsd.org> X-Mailer: Apple Mail (2.1510) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Sep 2013 22:05:27 -0000 --Apple-Mail=_3A138EFF-51E4-4225-AC3A-C67DB491AEB7 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 23, 2013, at 00:03, Dimitry Andric wrote: > Author: dim > Date: Sun Sep 22 22:03:30 2013 > New Revision: 255804 > URL: http://svnweb.freebsd.org/changeset/base/255804 > > Log: > Pull in r191165 from upstream llvm trunk: > > ISelDAG: spot chain cycles involving MachineNodes > > Previously, the DAGISel function WalkChainUsers was spotting that it > had entered already-selected territory by whether a node was a > MachineNode (amongst other things). Since it's fairly common practice > to insert MachineNodes during ISelLowering, this was not the correct > check. > > Looking around, it seems that other nodes get their NodeId set to -1 > upon selection, so this makes sure the same thing happens to all > MachineNodes and uses that characteristic to determine whether we > should stop looking for a loop during selection. > > This should fix PR15840. > > Specifically, this fixes the long-standing assertion failure when > compiling the multimedia/gstreamer port on i386. Thanks to Tijl > Coosemans for his help in getting upstream to fix it. > > Approved by: re (marius) MFC after: 3 days --Apple-Mail=_3A138EFF-51E4-4225-AC3A-C67DB491AEB7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI/aaMACgkQsF6jCi4glqPOQwCfWhHkw2NxAtnzeNheaI9Wno7V 6CIAn0ICLjCrg8onPhj53dwjkhrlI6zz =rFia -----END PGP SIGNATURE----- --Apple-Mail=_3A138EFF-51E4-4225-AC3A-C67DB491AEB7--