From owner-freebsd-ports@freebsd.org  Mon Jun 27 21:42:12 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89618B847E0
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Mon, 27 Jun 2016 21:42:12 +0000 (UTC)
 (envelope-from rodrigo@freebsd.org)
Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [IPv6:2a01:e0c:1:1599::10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5AB0E261B
 for <freebsd-ports@freebsd.org>; Mon, 27 Jun 2016 21:42:12 +0000 (UTC)
 (envelope-from rodrigo@freebsd.org)
Received: from [192.168.1.32] (unknown [78.194.61.125])
 by smtp1-g21.free.fr (Postfix) with ESMTP id 1E9C2B00294
 for <freebsd-ports@freebsd.org>; Mon, 27 Jun 2016 21:38:45 +0200 (CEST)
Subject: Re: pkg SAT_SOLVER bugs
To: freebsd-ports@freebsd.org
References: <20150414200459.GE39658@ivaldir.etoilebsd.net>
 <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org>
 <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org>
From: Rodrigo OSORIO <rodrigo@freebsd.org>
Message-ID: <81eaaea2-edc7-9337-0b53-ff6df1c1beca@freebsd.org>
Date: Mon, 27 Jun 2016 23:42:08 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jun 2016 21:42:12 -0000

On 06/27/16 12:38, Hans Petter Selasky wrote:
> Hi,
>
> I found some bugs in PKG with regard to the SAT_SOLVER environment
> variable. Please find patch attached :-)
>
> Issues fixed:
> 1) No need to use hash table when generating SAT rules for external
> solver. Variables are already in a linear array. Fix encoding and
> decoding of SAT data.
> 2) Endless variable loop caused pkg to crash.
> 3) it->inverse was checked for non-zero, while it should actually be
> checked for -1 only. SAT rules produces were all negative.
>
> How to verify:
>
> make -C /usr/ports/math/picosat all install clean
>
> env SAT_SOLVER=picosat pkg upgrade
>
> --HPS
>
>
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
>

Thanks! this patch saves my day, I was stuck reinstalling a computer in 
current, and after few rounds using pkg the solver start complaining and 
pretending missing packages was yet installed.

I apply you patch on top of the last version in ports and the patch work 
as a charm. I'll keep testing it until a new version comes.

regards,
- rodrigo