From owner-cvs-all Fri Apr 19 6:46:34 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 26EF037B426; Fri, 19 Apr 2002 06:46:27 -0700 (PDT) Received: (from rwatson@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g3JDkR942486; Fri, 19 Apr 2002 06:46:27 -0700 (PDT) (envelope-from rwatson) Message-Id: <200204191346.g3JDkR942486@freefall.freebsd.org> From: Robert Watson Date: Fri, 19 Apr 2002 06:46:27 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern uipc_syscalls.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG rwatson 2002/04/19 06:46:27 PDT Modified files: sys/kern uipc_syscalls.c Log: In sendfile(), use the vn_rdwr() helper function, rather than manually constructing a struct aio and invoking VOP_READ() directly. This cleans up the code a little, but also has the advantage of making sure almost all vnode read/write access in the kernel goes through the helper function, meaning that instrumentation of that helper function can impact almost all relevant read/write operations. In this case, it permits us to put MAC hooks into vn_rdwr() and not modify uipc_syscalls.c (yet). In general, if helper vn_*() functions exist, they should be used in preference to direct VOP's in system call service code. Submitted by: green Obtained from: TrustedBSD Project Sponsored by: DARPA, NAI Labs Revision Changes Path 1.109 +4 -13 src/sys/kern/uipc_syscalls.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message