Date: Thu, 4 Jul 2013 18:43:40 +0400 (MSK) From: Anes Mukhametov <anes@anes.su> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/180260: [PATCH] ports-mgmt/portlint: fix CPAN url hint Message-ID: <201307041443.r64Ehe9H059356@monitoring.rambler.ru> Resent-Message-ID: <201307041450.r64Eo1C7075723@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 180260 >Category: ports >Synopsis: [PATCH] ports-mgmt/portlint: fix CPAN url hint >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jul 04 14:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Anes Mukhametov >Release: >Organization: >Environment: >Description: Portlint tells about URL changing when CPAN URL is incorrect: E.g.: WARN: /a/ports/databases/p5-DBIx-Class-CustomPrefetch/pkg-descr: consider changing WWW URL to http://search.cpan.org/dist/DBIx-Class-CustomPrefetch At the same time it requeres a URL to end with slash. Attached patch to hint with terminating slash. >How-To-Repeat: >Fix: --- portlint.pl.diff begins here --- Index: ports/head/ports-mgmt/portlint/src/portlint.pl =================================================================== --- ports/head/ports-mgmt/portlint/src/portlint.pl.orig (revision 322277) +++ ports/head/ports-mgmt/portlint/src/portlint.pl (working copy) @@ -524,7 +524,7 @@ } if ($wwwurl =~ m|^http://search.cpan.org/~|) { &perror("WARN", $file, -1, "consider changing WWW URL to ". - "http://search.cpan.org/dist/$makevar{PORTNAME}"); + "http://search.cpan.org/dist/$makevar{PORTNAME}/"); } } $linecnt++; --- portlint.pl.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307041443.r64Ehe9H059356>