Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Jan 2017 12:14:31 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 215989] shells/lshell: Update to 0.9.18, take MAINTAINER'ship
Message-ID:  <bug-215989-13-ftQ2kgCsZc@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-215989-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-215989-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215989

--- Comment #11 from Damien Fleuriot <dam@my.gd> ---
Kindly find attached the svn diff to bring lshell up to the latest commit h=
ash
279d7ab [1]



* The port passes both 'portlint -C' and 'port test'.
* The offsets for files/patch-lshell_checkconfig.py have been adjusted to t=
his
latest commit hash.
* The patch files/patch-lshell_shellcmd.py needs to be removed since a lot =
of
code was refactored in 0.9.17.

I am unclear as to whether I should handle the extraneous patch file's dele=
tion
in post-extract ?
Quote [2] : If a file must be deleted, do it in the post-extract target rat=
her
than as part of the patch.



Seeing as we're fetching against a commit hash, I've taken the liberty of
setting PORTREVISION to the commit's date.

I believe this also elegantly solves the problem of having no 0.9.19 releas=
e.


I'll gladly heed any advice if you think there is yet room for improvement.




Will submit confirmation of poudriere runs as soon as I get a HEAD host up =
with
the proper jails.
The port does pass "manual checks" on 10-STABLE , as in managing to run it =
and
failing to exploit previous shell escape vulnerabilities.




[1]
https://github.com/ghantoos/lshell/commit/279d7ab7980ed88c6628e6621918f6299=
a2e2e32
[2] https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-215989-13-ftQ2kgCsZc>